Skip to content

refactor: create go.mod for store#14746

Merged
tac0turtle merged 18 commits into
mainfrom
likhita/store-go-mod
Jan 25, 2023
Merged

refactor: create go.mod for store#14746
tac0turtle merged 18 commits into
mainfrom
likhita/store-go-mod

Conversation

@likhita-809

Copy link
Copy Markdown
Contributor

Description

Closes: #14668


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 marked this pull request as ready for review January 24, 2023 08:01
@likhita-809 likhita-809 requested a review from a team January 24, 2023 08:01
@ghost ghost requested review from a team, kocubinski and tac0turtle and removed request for a team January 24, 2023 08:01
Comment thread store/go.mod Outdated
Comment thread simapp/go.mod Outdated
Comment thread store/sonar-project.properties
Comment thread store/go.mod Outdated
Comment thread tests/go.mod
Comment thread store/go.mod
@github-actions github-actions Bot removed C:Confix C:x/tx C:Cosmovisor Issues and PR related to Cosmovisor labels Jan 24, 2023
@EmilGeorgiev

Copy link
Copy Markdown
Contributor

I can't see the README.md file in the directory store. Should it be added in this PR?

@likhita-809

likhita-809 commented Jan 25, 2023

Copy link
Copy Markdown
Contributor Author

I can't see the README.md file in the directory store. Should it be added in this PR?

not the README.md, but CHANGELOG.md is added here

@julienrbrt julienrbrt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Comment thread store/dbadapter/store_test.go
@EmilGeorgiev

Copy link
Copy Markdown
Contributor

lgtm

@tac0turtle tac0turtle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow nicely done.

@tac0turtle tac0turtle enabled auto-merge (squash) January 25, 2023 10:11
@julienrbrt julienrbrt force-pushed the likhita/store-go-mod branch from c944555 to 4eb446c Compare January 25, 2023 12:18
@tac0turtle tac0turtle merged commit 7559d9e into main Jan 25, 2023
@tac0turtle tac0turtle deleted the likhita/store-go-mod branch January 25, 2023 13:31
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Co-authored-by: Marko <marbar3778@yahoo.com>
lukasz-zimnoch added a commit to mezo-org/mezod that referenced this pull request Jul 31, 2024
In Cosmos `0.50.x`, the aforementioned `store` package became a standalone
module placed under `cosmossdk.io` namespace. Here we adjust our codebase
to this change.

See: cosmos/cosmos-sdk#14746 and
https://docs.cosmos.network/main/build/migrations/upgrading#extract-store-to-a-standalone-module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

store: create a go.mod for store

4 participants