fix: x/capability InitMemStore should not consume gas

[prettymuchbryce]

Description

Closes: #15015

The capability module's InitMemStore function increments gasMeter non-deterministically across validators.

When a validator is restarted, InitMemStore is called during BeginBlock of the next committed block. This function performs some store operations which increment GasUsed on the GasMeter here.

So long as SetGasMeter is always called as part of the AnteHandler chain (which is the current behavior of the default AnteHandler chain here), then this is not an issue as the GasMeter will be reset between BeginBlock and the first DeliverTx call.

However, if the application uses a custom AnteHandler chain that omits this behavior, the GasUsed within each transaction will vary, as the GasMeter will be the initial meter set during BeginBlock here which increments gas differently if the capability module's MemStore has not yet been initialized.

As a solution, this PR adds WithGasMeter to the noGasCtx here which ensures that InitMemStore consumes no gas from GasMeter.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[prettymuchbryce]

I am not sure what is going on with the Lint job in CI, but the failures look unrelated to my changes.

[alexanderbez]

👏

Thanks @prettymuchbryce!

Yeah, you can ignore the lint stuff for now...not sure what's up with that.

[atheeshp]

lgtm, a nit

[atheeshp]

Suggested change

	suite.Require().Equal(prevBlockGas, blockGasUsed, "beginblocker consumed block gas during execution")
	suite.Require().Equal(prevBlockGas, blockGasUsed, "ensure beginblocker consume no block gas during execution")

can you update the below check's description as well.

[AdityaSripal]

Thanks!

[amaury1093]

@prettymuchbryce could you merge/rebase main so that our bot automerges this PR? Or altnertively give write access to maintainers

[prettymuchbryce]

@AmauryM I rebased onto main, but it looks like this disabled auto-merge.