Skip to content

chore: use message router interface#15213

Merged
tac0turtle merged 3 commits into
mainfrom
marko/router_interface_cleanup
Feb 28, 2023
Merged

chore: use message router interface#15213
tac0turtle merged 3 commits into
mainfrom
marko/router_interface_cleanup

Conversation

@tac0turtle

@tac0turtle tac0turtle commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

Description

use message router interface instead of concrete impl throughout
ref: #15035


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle marked this pull request as ready for review February 28, 2023 10:33
@tac0turtle tac0turtle requested a review from a team February 28, 2023 10:33
@ghost ghost requested review from a team, alexanderbez and kocubinski and removed request for a team February 28, 2023 10:33

@likhita-809 likhita-809 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread CHANGELOG.md Outdated
@tac0turtle tac0turtle merged commit 17ba80d into main Feb 28, 2023
@tac0turtle tac0turtle deleted the marko/router_interface_cleanup branch February 28, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants