feat: add event core api to runtime#15547
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
alexanderbez
approved these changes
Mar 27, 2023
alexanderbez
left a comment
Contributor
There was a problem hiding this comment.
We should probably add a few simple test cases for this type.
julienrbrt
reviewed
Mar 27, 2023
julienrbrt
approved these changes
Mar 28, 2023
aaronc
reviewed
Mar 28, 2023
aaronc
reviewed
Mar 28, 2023
Contributor
Author
where should the tests exist? runtime doesnt seem to have tests |
aaronc
reviewed
Mar 28, 2023
facundomedica
approved these changes
Mar 30, 2023
nicolaslara
pushed a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Mar 31, 2023
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #14690
Opening this pr to get initial feedback on the approach. If this is good then i can plumb it through baseapp
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change