feat: update store module for new iavl by cool-develope · Pull Request #15568 · cosmos/cosmos-sdk

cool-develope · 2023-03-28T12:49:51Z

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

tac0turtle

before merging this we need an issue on how to do migrations

elias-orijtech

LGTM apart from nits.

tac0turtle · 2023-04-11T10:00:47Z

build doesnt pass

tac0turtle · 2023-04-17T12:42:51Z

waiting to merge this until we have migrations tested as this merge would signify the adoption of this in the Eden release

odeke-em

Thank you for this change @cool-develope, I've added my first round of review, please take a look.

tac0turtle · 2023-05-07T10:50:30Z

-		LazyLoadVersionForOverwriting(targetVersion int64) (int64, error)
+		LoadVersionForOverwriting(targetVersion int64) error
 		TraverseStateChanges(startVersion, endVersion int64, fn func(version int64, changeSet *iavl.ChangeSet) error) error
+		SaveChangeSet(changeSet *iavl.ChangeSet) (int64, error)


do we still need this api change?

it can be useful when create the migrating tool of the archived node.

since users can get this api from iavl lets remove it for now

This comment is still unimplemented.

cool-develope · 2023-05-22T21:23:55Z

@tac0turtle , we need new tag of iavl

tac0turtle · 2023-05-30T15:07:54Z

this is unblocked and can use v1.0.0-beta.2 of iavl

…ore/new_iavl

tac0turtle · 2023-05-30T21:04:44Z


 	// "restart"
 	ms = newMultiStoreWithMounts(db, pruningtypes.NewCustomPruningOptions(2, 11))
-	ms.SetSnapshotInterval(3)


i think we should still keep this so we dont break pruning dependence on snapshot intervals

for now, the snapshot interval doesn't affect the pruning strategy if we don't call HandleHeightSnapshot.

tac0turtle

Looks good. Been running this on juno for a week now

tac0turtle · 2023-06-03T04:16:12Z

lets resolve the conflicts then we can merge this

julienrbrt · 2023-06-03T06:15:05Z

+    - Remov `DeleteVersion`, `DeleteVersions`, `LazyLoadVersionForOverwriting` from `iavl` tree API.
+    - Add `DeleteVersionsTo` and `SaveChangeSet`, since it will keep versions sequentially like `fromVersion` to `toVersion`.
+    - Refactor the pruning manager to use `DeleteVersionsTo`.
+    - Remove `IAVLLazyLoading` option from baseapp.


This one should be in the main changelog ./CHANGELOG.md instead of under store/CHANGELOG.md

julienrbrt · 2023-06-03T06:16:34Z

-		LazyLoadVersionForOverwriting(targetVersion int64) (int64, error)
+		LoadVersionForOverwriting(targetVersion int64) error
 		TraverseStateChanges(startVersion, endVersion int64, fn func(version int64, changeSet *iavl.ChangeSet) error) error
+		SaveChangeSet(changeSet *iavl.ChangeSet) (int64, error)


This comment is still unimplemented.

julienrbrt · 2023-06-03T06:18:33Z

-	if err != nil {
-		return err
+	// Consider the snapshot height
+	pruneHeight := height - 1 - int64(m.opts.KeepRecent) // we should keep the current height at least


What if pruneHeight gets negative?

this will be checked in PruneStores when pruning in rootmulti

julienrbrt · 2023-06-03T06:19:42Z

 	github.com/cosmos/cosmos-db v1.0.0
 	github.com/cosmos/gogoproto v1.4.10
-	github.com/cosmos/iavl v0.21.0
+	github.com/cosmos/iavl v1.0.0-beta.1


nit, use v1.0.0-beta.2

julienrbrt

utACK, few nits

alexanderbez · 2023-06-05T14:34:48Z

Let's get @julienrbrt's suggestions in and we can merge. The conflicts should be trivial to resolve.

cool-develope requested a review from a team March 28, 2023 12:49

cool-develope marked this pull request as draft March 28, 2023 12:49

github-actions Bot added the C:Store label Mar 28, 2023

ghost requested review from a team, facundomedica and likhita-809 and removed request for a team March 28, 2023 12:50

This comment has been minimized.

Sign in to view

kocubinski self-assigned this Mar 28, 2023

cool-develope marked this pull request as ready for review March 29, 2023 20:42

ghost self-requested a review March 29, 2023 20:42

tac0turtle assigned JeancarloBarrios Mar 30, 2023

tac0turtle reviewed Mar 31, 2023

View reviewed changes

Comment thread store/rootmulti/store_test.go Outdated

tac0turtle assigned testinginprod Apr 6, 2023

alexanderbez approved these changes Apr 7, 2023

View reviewed changes

Comment thread store/iavl/store.go Outdated

julienrbrt mentioned this pull request Apr 7, 2023

build(deps): Bump github.com/cosmos/iavl from 0.21.0-beta.1 to 1.0.0-alpha.2 in /store #15745

Closed

tac0turtle previously requested changes Apr 8, 2023

View reviewed changes

cool-develope mentioned this pull request Apr 10, 2023

[Epic]: migration of the new store module #15769

Closed

elias-orijtech reviewed Apr 10, 2023

View reviewed changes

Comment thread store/pruning/manager.go

Comment thread store/rootmulti/store_test.go Outdated

cool-develope requested a review from elias-orijtech April 12, 2023 13:01

odeke-em reviewed Apr 25, 2023

View reviewed changes

Comment thread store/pruning/manager.go Outdated

Comment thread store/pruning/manager.go Outdated

tac0turtle added the S:blocked Status: Blocked label Apr 25, 2023

github-actions Bot added C:CLI C:collections C:Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:Keys Keybase, KMS and HSMs labels Apr 26, 2023

cool-develope removed C:orm Type: Build labels Apr 26, 2023

tac0turtle reviewed May 7, 2023

View reviewed changes

Comment thread store/iavl/tree.go

tac0turtle reviewed May 7, 2023

View reviewed changes

Comment thread store/iavl/store.go

cool-develope added 2 commits May 22, 2023 17:12

Merge branch 'main' into store/new_iavl

3486099

go mod tidy

d4cccb5

add changelog

f71ceb0

cool-develope and others added 8 commits May 30, 2023 08:15

Merge branch 'main' into store/new_iavl

75480ee

iavl version

9258f51

simapp go mod

9401763

Merge branch 'main' into store/new_iavl

572a734

go mod tidy

0df84b7

Merge branch 'store/new_iavl' of github.com:cosmos/cosmos-sdk into st…

46c9b15

…ore/new_iavl

go dep update

f562b91

Merge branch 'main' into store/new_iavl

add27df

tac0turtle reviewed May 30, 2023

View reviewed changes

tac0turtle approved these changes May 31, 2023

View reviewed changes

julienrbrt mentioned this pull request Jun 3, 2023

build(deps): Bump github.com/cosmos/iavl from 0.21.0 to 0.21.1 in /store #16411

Closed

julienrbrt reviewed Jun 3, 2023

View reviewed changes

julienrbrt approved these changes Jun 3, 2023

View reviewed changes

cool-develope added 5 commits June 6, 2023 12:39

suggestions

b34a13a

Merge branch 'main' into store/new_iavl

59c86db

go mod tidy

11365c0

fix the store test

58e7aa0

revert hubl and cosmovisor go.mod

c55a8ca

Conversation

cool-develope commented Mar 28, 2023

Description

Author Checklist

Reviewers Checklist

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

tac0turtle left a comment

Choose a reason for hiding this comment

Uh oh!

elias-orijtech left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tac0turtle commented Apr 11, 2023

Uh oh!

tac0turtle commented Apr 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odeke-em left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

julienrbrt Jun 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cool-develope commented May 22, 2023

Uh oh!

tac0turtle commented May 30, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tac0turtle left a comment

Choose a reason for hiding this comment

Uh oh!

tac0turtle commented Jun 3, 2023

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

julienrbrt Jun 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

julienrbrt left a comment

Choose a reason for hiding this comment

Uh oh!

alexanderbez commented Jun 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

tac0turtle commented Apr 17, 2023 •

edited

Loading

julienrbrt Jun 3, 2023 •

edited

Loading

julienrbrt Jun 3, 2023 •

edited

Loading