refactor(staking)!: binary format for HistoricalInfoKey#15701
Merged
mergify[bot] merged 14 commits intoApr 13, 2023
Conversation
babadro
changed the title
babadro
changed the title
4 tasks
Contributor
Author
|
Early feedback is appreciated. |
tac0turtle
reviewed
Apr 5, 2023
tac0turtle
left a comment
tac0turtle
left a comment
Contributor
There was a problem hiding this comment.
migration should be handled in this pr. you can checkout the migation folder to see how it is done
alexanderbez
reviewed
Apr 5, 2023
alexanderbez
left a comment
alexanderbez
left a comment
Contributor
There was a problem hiding this comment.
Looking good so far! Lets be sure to have exhaustive test coverage
babadro
force-pushed
the
11463-binary-historical-info-key
branch
from
df71bc9 to
c0e556c
Compare
babadro
force-pushed
the
11463-binary-historical-info-key
branch
from
c0e556c to
c313538
Compare
ghost
requested review from
a team,
alexanderbez and
atheeshp
and removed request for
a team
alexanderbez
approved these changes
Apr 10, 2023
|
|
||
| ### State Machine Breaking | ||
|
|
||
| * (x/staking) [#15701](https://github.com/cosmos/cosmos-sdk/pull/15701) The `HistoricalInfoKey` has been updated to use a binary format. |
Contributor
There was a problem hiding this comment.
This is in the wrong section. Move it up to the unreleased section above.
cool-develope
approved these changes
Apr 12, 2023
julienrbrt
changed the title
Contributor
|
@babadro could you run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #11463
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change