fix: call AfterUnbondingInitiated for new unbonding entries only#16043
Merged
Conversation
Contributor
|
Can we get a changelog + a test here? |
Contributor
Author
Yes. I'll add the tests and the changelog 👍 |
18 tasks
18 tasks
Contributor
|
Currently working on: Just curious if this will be able to be backported to 47, or if we need to begin to target main. Thanks. |
alexanderbez
approved these changes
May 8, 2023
f06b4bf to
9867dd7
Compare
Contributor
Author
|
@julienrbrt Tests and changelog entries were added. |
Contributor
|
Thanks, could you fix the linting issues? |
Contributor
Author
Fixed! |
julienrbrt
approved these changes
May 9, 2023
julienrbrt
left a comment
Contributor
There was a problem hiding this comment.
lgtm! However, I do not think we can backport that to v0.47 🤔
Contributor
|
Reminder for myself, precise a behavior change in the UPGRADING.md and/or changelog. |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #16042
An earlier change in #12967 introduced behaviour that causes the
AfterUnbondingInitiatedstaking hook to be called with an invalidunbondingIdinSetUnbondingDelegationEntry. The issue affects unbonding operations, redelegation behaviour does not seem to be affected. The issue can cause interchain-security provider chains to panic.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change