feat(auth): autocli query support#16650
Merged
Merged
Conversation
This was referenced Jun 22, 2023
ghost
requested review from
a team,
alexanderbez and
atheeshp
and removed request for
a team
atheeshp
reviewed
Jul 10, 2023
Comment on lines
-108
to
-124
| queryClient := types.NewQueryClient(clientCtx) | ||
| res, err := queryClient.Account(cmd.Context(), &types.QueryAccountRequest{Address: args[0]}) | ||
| if err != nil { | ||
| node, err2 := clientCtx.GetNode() | ||
| if err2 != nil { | ||
| return err2 | ||
| } | ||
| status, err2 := node.Status(context.Background()) | ||
| if err2 != nil { | ||
| return err2 | ||
| } | ||
| catchingUp := status.SyncInfo.CatchingUp | ||
| if !catchingUp { | ||
| return errorsmod.Wrapf(err, "your node may be syncing, please check node status using `/status`") | ||
| } | ||
| return err | ||
| } |
Contributor
There was a problem hiding this comment.
@julienrbrt , I always had a doubt how are these cases going to be handled with autoCLI?
Contributor
Author
There was a problem hiding this comment.
This command was the only one in this SDK having this check. Given AutoCLI simply just uses gRPC, the CLI has the same behavior as the gRPC endpoints (in this case querying /cosmos/auth/v1beta1/accounts/<addr>).
mergify Bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
(cherry picked from commit 81b7049)
julienrbrt
added a commit
that referenced
this pull request
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ref: #15901
blocked by #16743
There is a significant amount of duplicated tests in auth (integration and e2e), I have removed the one CLI related, but the rest should be de-duplicated as part of #16757
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change