refactor: introduce abciGenesis interface #17554
Merged
Merged
Conversation
github-actions
Bot
added
C:x/gov
C:x/slashing
C:x/distribution
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
553
to
512
Check notice
Code scanning / CodeQL
Spawning a Go routine
julienrbrt
reviewed
Aug 27, 2023
tac0turtle
force-pushed
the
marko/genesis_comet_separation
branch
from
9f47982 to
f1576d7
Compare
julienrbrt
reviewed
Aug 28, 2023
alexanderbez
approved these changes
Aug 28, 2023
julienrbrt
reviewed
Aug 28, 2023
tac0turtle
force-pushed
the
marko/genesis_comet_separation
branch
from
45ce416 to
f8f414c
Compare
julienrbrt
reviewed
Aug 29, 2023
julienrbrt
reviewed
Aug 29, 2023
| :::note | ||
| Use `appmodule.HasGenesis` instead. | ||
| ::: | ||
| ### `HasGenesis` |
Contributor
There was a problem hiding this comment.
Can we maybe have a category grouping those like we do for the others?
# HasGenesis
## module.HasGenesis
Lorem ipsum
## module.HasABCIGenesis
Lorem ipsum
## appmodule.HasGenesis
Unstable, do not use.
julienrbrt
reviewed
Aug 29, 2023
julienrbrt
approved these changes
Aug 29, 2023
julienrbrt
left a comment
julienrbrt
left a comment
Contributor
There was a problem hiding this comment.
lgtm!
Note for later: In the backport the deleted interfaces should be brought back and deprecated.
mergify Bot
pushed a commit
that referenced
this pull request
Aug 29, 2023
(cherry picked from commit 6ce2505) # Conflicts: # CHANGELOG.md # x/circuit/go.sum # x/evidence/go.mod # x/evidence/go.sum # x/feegrant/go.sum # x/nft/go.sum
julienrbrt
pushed a commit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ref #17425
this pr introduces a
HasABCIGenesisinterface in order to decouple from comet prior to genesis design rewrite. It also marks the current core module genesis interface as experimental and can change at any timeAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change