fix(sim): set FlagSigverifyTxValue to newApp for TestAppSimulationAfterImport#18289
Merged
Merged
Conversation
Contributor
WalkthroughThe update introduces a conditional check in the Changes
TipsChat with CodeRabbit Bot (
|
ghost
requested review from
a team,
alexanderbez and
likhita-809
and removed request for
a team
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
likhita-809
approved these changes
Oct 30, 2023
tac0turtle
approved these changes
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #17911, I added a new SigverifyTx flag whether to verify the signature of the transaction. But I forgot that TestAppSimulationAfterImport passed this flag to the newApp of this test. Now just add the relevant logic.
Summary by CodeRabbit
TestAppSimulationAfterImportfunction to handle a new scenario. This update allows the simulation test to bypass transaction signature verification when theFlagSigverifyTxValueflag is set to false. This change improves the flexibility of our testing environment and ensures more robust application testing.