Skip to content

fix(x/gov): backport - limit deposited coins to accepted proposal denom PR 18189#19302

Merged
mpoke merged 1 commit into
cosmos:feature/v0.47.x-ics-lsmfrom
informalsystems:stana/gov-limit-deposit
Jan 31, 2024
Merged

fix(x/gov): backport - limit deposited coins to accepted proposal denom PR 18189#19302
mpoke merged 1 commit into
cosmos:feature/v0.47.x-ics-lsmfrom
informalsystems:stana/gov-limit-deposit

Conversation

@stana-miric

Copy link
Copy Markdown

Description

Backport of PR 18189


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@stana-miric stana-miric requested a review from a team January 31, 2024 06:58

@mpoke mpoke left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @stana-miric

@mpoke mpoke merged commit ec27b79 into cosmos:feature/v0.47.x-ics-lsm Jan 31, 2024
@stana-miric stana-miric deleted the stana/gov-limit-deposit branch February 7, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants