fix(x/gov): Backport of pull request #18173 to feature/v.0.47.x-ics-lsm branch#19305
Merged
mpoke merged 1 commit intoFeb 1, 2024
Merged
Conversation
dusan-maksimovic
force-pushed
the
dusan/gov-hooks
branch
from
5508d90 to
5c95e82
Compare
MSalopek
approved these changes
Jan 31, 2024
MSalopek
left a comment
MSalopek
left a comment
Contributor
There was a problem hiding this comment.
@dusan-maksimovic Thanks!
LGTM
mattverse
pushed a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Feb 6, 2024
…-ics-lsm branch (cosmos#19305)
19 tasks
czarcas7ic
added a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Mar 9, 2024
* fix(x/gov): Backport of pull request cosmos#18173 to feature/v.0.47.x-ics-lsm branch (cosmos#19305) * update changelog --------- Co-authored-by: Dusan Maksimovic <94966669+dusan-maksimovic@users.noreply.github.com> Co-authored-by: Adam Tucker <adamleetucker@outlook.com> Co-authored-by: Adam Tucker <adam@osmosis.team>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of PR #18173: Introduce & handle errors returned by the gov module hooks
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...