Skip to content

build(deps): bump to cosmossdk.io/api v0.7.3#19376

Merged
julienrbrt merged 2 commits into
release/v0.50.xfrom
julien/api-050
Feb 19, 2024
Merged

build(deps): bump to cosmossdk.io/api v0.7.3#19376
julienrbrt merged 2 commits into
release/v0.50.xfrom
julien/api-050

Conversation

@julienrbrt

@julienrbrt julienrbrt commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

Description

Closes: #19374

Attempt to use the latest api from main in release/v0.50.x to fix the issue where api v0.7.2 didn't contain the released changes from gov.

We should still verift how autocli reacts given that we will be adding unreleased things into api (normally this #18324 should nicely hide those commands, but let's see).

Once I confirm everything works in CI and locally, we can tag api v0.7.3 and bump it here.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@julienrbrt

Copy link
Copy Markdown
Contributor Author

I guess we need to fix this first:

// TODO this does not work, to fix.
otherwise autocli cannot read the since comments.

@julienrbrt julienrbrt mentioned this pull request Feb 16, 2024
12 tasks
@julienrbrt

julienrbrt commented Feb 16, 2024

Copy link
Copy Markdown
Contributor Author

EDIT: because we want this to be fixed sooner than later (in v0.50.4), and cosmos/cosmos-proto#131 takes longer than expected. I'll make a cosmossdk.io/api v0.7.3 cherry-picking this change, so we don't need to bump api to latest.
However, the changes from #19377 and cosmos/cosmos-proto#131 are eventually still needed.

@julienrbrt julienrbrt changed the title fix: attempt to use latest api build(deps): bump to cosmossdk.io/api v0.7.3 Feb 16, 2024
Comment thread go.mod Outdated

require (
cosmossdk.io/api v0.7.2
cosmossdk.io/api v0.7.3-0.20240216161322-c0ecaf7cf2f1

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julienrbrt julienrbrt marked this pull request as ready for review February 16, 2024 16:24
@julienrbrt julienrbrt requested review from a team, facundomedica and tac0turtle February 16, 2024 16:24
@julienrbrt julienrbrt enabled auto-merge (squash) February 16, 2024 16:24
@julienrbrt julienrbrt merged commit cc0b5c4 into release/v0.50.x Feb 19, 2024
@julienrbrt julienrbrt deleted the julien/api-050 branch February 19, 2024 04:30
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants