chore: fix codeql issue

[tac0turtle]

Description

this pr fixes a codeql issue and some exsiting linting issues

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Refactor
  • Improved error handling in security operations by updating data types.
• Chores
  • Removed an unused import to enhance code cleanliness and efficiency.
• Tests
  • Updated integration tests for authentication to use more accurate dependencies and message types.

[coderabbitai]

Walkthrough

Walkthrough

This update introduces changes across several files, enhancing error handling in bcrypt operations, cleaning up code by removing unused imports, and refining the organization of imports and message types in test cases. These modifications aim to improve code efficiency, readability, and maintainability.

Changes

File Path	Change Summary
crypto/keys/bcrypt/bcrypt.go	Changed the type declaration from InvalidCostError int to InvalidCostError uint32 to improve error handling in bcrypt operations.
simapp/.../app_config.go	Removed an unused import statement for cosmossdk.io/x/accounts.
tests/integration/auth/.../msg_server_test.go	Renamed and reorganized imports related to auth and bank packages. Updated test cases to use authtypes.MsgNonAtomicExec for message requests.

---

Recent Review Details

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between f31a6a3 and d1ba057.

Files selected for processing (3)

• crypto/keys/bcrypt/bcrypt.go (1 hunks)
• simapp/app_config.go (1 hunks)
• tests/integration/auth/keeper/msg_server_test.go (7 hunks)

Files skipped from review due to trivial changes (1)

• simapp/app_config.go

Additional Context Used

Path-based Instructions (2)

tests/integration/auth/keeper/msg_server_test.go (3)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

---

Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"

---

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

crypto/keys/bcrypt/bcrypt.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (2)

tests/integration/auth/keeper/msg_server_test.go (1)

217-239: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [187-245]

Ensure test cases cover all scenarios for MsgNonAtomicExec.

The test cases have been updated to use authtypes.MsgNonAtomicExec. Verify that all relevant scenarios are covered, including edge cases and error handling. Consider adding tests for scenarios not currently covered to ensure comprehensive testing.

crypto/keys/bcrypt/bcrypt.go (1)

50-50: Type change in InvalidCostError enhances type safety.

Changing InvalidCostError from int to uint32 is a positive change as it aligns better with the constants MinCost and MaxCost, which are also of type uint32. This change enhances type safety and consistency in the codebase.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.