ci: add 52 labels and ci#21041
Conversation
WalkthroughWalkthroughThis update introduces a new GitHub Actions workflow for the Sims project, enhancing CI/CD capabilities for version 0.52.x. The workflow automates simulation tests and includes Slack notifications for success and failure. Additionally, a backporting rule is added to facilitate patch management for the Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/sims-052.yml (1 hunks)
- .mergify.yml (1 hunks)
Additional comments not posted (5)
.mergify.yml (1)
19-26: LGTM! But verify the label usage.The new backport rule for
release/v0.52.xis correctly defined and follows the existing pattern.However, ensure that the label
backport/v0.52.xis used consistently in the repository..github/workflows/sims-052.yml (4)
14-27: LGTM! Thebuildjob is correctly defined.The
buildjob checks out the code, sets up Go, and runs the build command.
28-44: LGTM! Theinstall-runsimjob is correctly defined.The
install-runsimjob installs therunsimtool and caches the Go binary.
45-64: LGTM! Thetest-sim-import-exportjob is correctly defined.The
test-sim-import-exportjob runs thetest-sim-import-exporttest.
65-83: LGTM! Thetest-sim-after-importjob is correctly defined.The
test-sim-after-importjob runs thetest-sim-after-importtest.
|
Can we add dependabot check on that branch too (like) https://github.com/cosmos/cosmos-sdk/blob/main/.github/dependabot.yml#L335-L358? |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/sims-052.yml (1 hunks)
- .mergify.yml (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- .github/workflows/sims-052.yml
- .mergify.yml
| dependency-type: "all" | ||
| - dependency-name: "github.com/cometbft/*" | ||
| dependency-type: "all" | ||
| ignore: |
There was a problem hiding this comment.
we can remove that whole ignore section as we use cometbft v1 in main/v0.52
|
Last point, can we rename Line 40 in 2c236af |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- .github/dependabot.yml (1 hunks)
Additional comments not posted (2)
.github/dependabot.yml (2)
360-378: LGTM! New configuration block for Go module dependencies is consistent with existing patterns.The new configuration block for managing Go module dependencies targeting the
release/v0.52.xbranch is consistent with the existing patterns in the file.
359-359: Verify the removal of theignoresection forcometbftdependencies.There is an existing comment suggesting the removal of the
ignoresection forcometbftdependencies sincecometbft v1is used inmain/v0.52.Verification successful
The
ignoresection forcometbftdependencies has been removed. The current configuration mentionscometbftdependencies in other contexts but not in anignoresection.
- Lines mentioning
cometbftdependencies:
- dependency-name: "github.com/cometbft/*"- dependency-name: "github.com/cometbft/cometbft"Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the removal of the `ignore` section for `cometbft` dependencies. # Test: Search for the `ignore` section in the file. Expect: No `ignore` section for `cometbft` dependencies. rg --type yaml 'ignore' .github/dependabot.ymlLength of output: 70
Script:
#!/bin/bash # Description: Verify the removal of the `ignore` section for `cometbft` dependencies. # Test: Search for the `ignore` section specifically mentioning `cometbft` in the file. rg --type yaml 'ignore.*cometbft' .github/dependabot.ymlLength of output: 58
Script:
#!/bin/bash # Description: Verify if there are any mentions of `cometbft` in the file. # Test: Search for any mentions of `cometbft` in the file. rg --type yaml 'cometbft' .github/dependabot.ymlLength of output: 495
github-actions
Bot
added
C:x/slashing
C:x/distribution
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (27)
- client/v2/go.mod (1 hunks)
- client/v2/internal/testpb/msg.proto (2 hunks)
- server/v2/cometbft/go.mod (1 hunks)
- simapp/go.mod (1 hunks)
- simapp/v2/go.mod (1 hunks)
- tests/go.mod (1 hunks)
- x/accounts/defaults/lockup/go.mod (1 hunks)
- x/accounts/defaults/multisig/go.mod (1 hunks)
- x/accounts/go.mod (1 hunks)
- x/auth/go.mod (1 hunks)
- x/authz/go.mod (1 hunks)
- x/bank/go.mod (1 hunks)
- x/circuit/go.mod (1 hunks)
- x/consensus/go.mod (1 hunks)
- x/distribution/go.mod (1 hunks)
- x/epochs/go.mod (1 hunks)
- x/evidence/go.mod (1 hunks)
- x/feegrant/go.mod (1 hunks)
- x/gov/go.mod (1 hunks)
- x/group/go.mod (1 hunks)
- x/mint/go.mod (1 hunks)
- x/nft/go.mod (1 hunks)
- x/params/go.mod (1 hunks)
- x/protocolpool/go.mod (1 hunks)
- x/slashing/go.mod (1 hunks)
- x/staking/go.mod (1 hunks)
- x/upgrade/go.mod (1 hunks)
Files skipped from review due to trivial changes (1)
- client/v2/internal/testpb/msg.proto
Additional context used
Path-based instructions (1)
tests/go.mod (1)
Pattern
tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"
Additional comments not posted (26)
x/auth/go.mod (1)
19-19: Verify compatibility with updated Cosmos SDK version.The dependency version for
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure that this new version does not introduce breaking changes or unexpected behaviors in the application.x/consensus/go.mod (1)
15-15: Verify compatibility with updated Cosmos SDK version.The dependency version for
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure that this new version does not introduce breaking changes or unexpected behaviors in the application.x/staking/go.mod (1)
17-17: Verify compatibility with updated Cosmos SDK version.The dependency version for
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure that this new version does not introduce breaking changes or unexpected behaviors in the application.x/bank/go.mod (1)
17-17: Verify compatibility with the new SDK version.The
github.com/cosmos/cosmos-sdkdependency has been updated tov0.53.0. Ensure that the new version is compatible with the rest of the codebase and that all necessary changes have been made to accommodate this update.x/evidence/go.mod (1)
16-16: Verify compatibility with the new SDK version.The
github.com/cosmos/cosmos-sdkdependency has been updated tov0.53.0. Ensure that the new version is compatible with the rest of the codebase and that all necessary changes have been made to accommodate this update.x/epochs/go.mod (1)
14-14: Verify compatibility with the new SDK version.The
github.com/cosmos/cosmos-sdkdependency has been updated tov0.53.0. Ensure that the new version is compatible with the rest of the codebase and that all necessary changes have been made to accommodate this update.x/protocolpool/go.mod (1)
16-16: Update dependency version.The version of
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure compatibility with the new version and test thoroughly.Verification successful
All instances of
github.com/cosmos/cosmos-sdkhave been updated tov0.53.0.The search results show that the
go.modfiles across various modules in the codebase have been updated to usegithub.com/cosmos/cosmos-sdk v0.53.0. This confirms that the dependency version has been updated correctly throughout the codebase.
x/upgrade/go.modx/staking/go.modx/slashing/go.modx/mint/go.modx/protocolpool/go.modx/params/go.modx/nft/go.modx/group/go.modx/gov/go.modx/distribution/go.modx/epochs/go.modx/evidence/go.modx/feegrant/go.modx/bank/go.modx/authz/go.modx/consensus/go.modx/circuit/go.modx/accounts/go.modx/accounts/defaults/multisig/go.modx/accounts/defaults/lockup/go.modx/auth/go.modtests/go.modsimapp/go.modsimapp/v2/go.modserver/v2/cometbft/go.modruntime/v2/go.modclient/v2/go.modNote: Some tools (e.g.,
tools/cosmovisor,tools/hubl,tests/systemtests,tools/confix) are still using older versions of the dependency. Please verify if these tools also need to be updated.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all instances of `github.com/cosmos/cosmos-sdk` dependency in the codebase. # Test: Search for the dependency usage. Expect: Only instances of the new version. rg --type go 'github.com/cosmos/cosmos-sdk'Length of output: 375727
Script:
#!/bin/bash # Description: Verify that all instances of `github.com/cosmos/cosmos-sdk` are using the updated version `v0.53.0`. # Test: Search for the version string `v0.53.0` in the codebase. rg --type go 'github.com/cosmos/cosmos-sdk.*v0\.53\.0'Length of output: 56
Script:
#!/bin/bash # Description: Verify the versions of `github.com/cosmos/cosmos-sdk` dependency in all `go.mod` files in the codebase. # Test: Search for the `github.com/cosmos/cosmos-sdk` dependency in `go.mod` files and list their versions. rg --type go.mod 'github.com/cosmos/cosmos-sdk' -A 1Length of output: 83
Script:
#!/bin/bash # Description: Verify the versions of `github.com/cosmos/cosmos-sdk` dependency in all `go.mod` files in the codebase. # Test: Search for the `github.com/cosmos/cosmos-sdk` dependency in `go.mod` files and list their versions. rg 'github.com/cosmos/cosmos-sdk' -A 1 --glob '**/go.mod'Length of output: 6762
x/slashing/go.mod (1)
18-18: Update dependency version.The version of
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure compatibility with the new version and test thoroughly.x/nft/go.mod (1)
14-14: Update dependency version.The version of
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure compatibility with the new version and test thoroughly.Verification successful
Dependency version updated successfully
The version of
github.com/cosmos/cosmos-sdkhas been updated tov0.53.0across multiplego.modfiles in the codebase.
- Instances found in:
x/upgrade/go.modx/staking/go.modx/slashing/go.modx/protocolpool/go.modx/mint/go.modx/params/go.modx/nft/go.modx/group/go.modx/gov/go.modx/distribution/go.modx/evidence/go.modx/feegrant/go.modx/epochs/go.modx/consensus/go.modx/authz/go.modx/bank/go.modx/circuit/go.modx/auth/go.modx/accounts/go.modx/accounts/defaults/lockup/go.modx/accounts/defaults/multisig/go.modtests/go.modsimapp/go.modsimapp/v2/go.modserver/v2/cometbft/go.modclient/v2/go.modPlease ensure thorough testing to confirm compatibility with the new version.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all instances of `github.com/cosmos/cosmos-sdk` dependency in the codebase. # Test: Search for the dependency usage. Expect: Only instances of the new version. rg --type go 'github.com/cosmos/cosmos-sdk'Length of output: 375727
Script:
#!/bin/bash # Description: Verify the version of `github.com/cosmos/cosmos-sdk` dependency in all go.mod files. # Test: Search for the dependency version in go.mod files. Expect: Version v0.53.0. rg --type go 'github.com/cosmos/cosmos-sdk' --glob '**/go.mod'Length of output: 3952
x/authz/go.mod (1)
18-18: Upgrade to Cosmos SDK v0.53.0.The dependency update from
v0.51.0tov0.53.0should be verified for compatibility with the existing codebase. Ensure that the new SDK version does not introduce breaking changes or require additional modifications.x/circuit/go.mod (1)
14-14: Upgrade to Cosmos SDK v0.53.0.The dependency update from
v0.51.0tov0.53.0should be verified for compatibility with the existing codebase. Ensure that the new SDK version does not introduce breaking changes or require additional modifications.x/distribution/go.mod (1)
19-19: Upgrade to Cosmos SDK v0.53.0.The dependency update from
v0.51.0tov0.53.0should be verified for compatibility with the existing codebase. Ensure that the new SDK version does not introduce breaking changes or require additional modifications.x/mint/go.mod (1)
17-17: Verify compatibility with the updated Cosmos SDK version.The dependency version for
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure that all functionalities are compatible with this new version and that any breaking changes are addressed.x/gov/go.mod (1)
22-22: Verify compatibility with the updated Cosmos SDK version.The dependency version for
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure that all functionalities are compatible with this new version and that any breaking changes are addressed.x/accounts/defaults/lockup/go.mod (1)
12-12: Verify compatibility with the updated Cosmos SDK version.The dependency version for
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure that all functionalities are compatible with this new version and that any breaking changes are addressed.x/feegrant/go.mod (1)
18-18: Upgrade dependency version.The dependency version for
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure that all modules and code relying on this dependency are compatible with the new version.x/params/go.mod (1)
17-17: Upgrade dependency version.The dependency version for
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure that all modules and code relying on this dependency are compatible with the new version.server/v2/cometbft/go.mod (1)
35-35: Upgrade dependency version.The dependency version for
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure that all modules and code relying on this dependency are compatible with the new version.x/accounts/go.mod (1)
14-14: Verify compatibility with the updatedcosmos-sdkdependency.The dependency
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure that the module remains compatible with the new version and that no breaking changes are introduced.x/accounts/defaults/multisig/go.mod (1)
12-12: Verify compatibility with the updatedcosmos-sdkdependency.The dependency
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure that the module remains compatible with the new version and that no breaking changes are introduced.client/v2/go.mod (1)
13-13: Verify compatibility with the updatedcosmos-sdkdependency.The dependency
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure that the module remains compatible with the new version and that no breaking changes are introduced.x/group/go.mod (1)
26-26: Upgrade dependency version.The version of
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure that this upgrade does not introduce breaking changes and that all dependent code is compatible with the new version.x/upgrade/go.mod (1)
20-20: Upgrade dependency version.The version of
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure that this upgrade does not introduce breaking changes and that all dependent code is compatible with the new version.tests/go.mod (1)
25-25: Upgrade dependency version.The version of
github.com/cosmos/cosmos-sdkhas been updated fromv0.51.0tov0.53.0. Ensure that this upgrade does not introduce breaking changes and that all dependent code is compatible with the new version.simapp/go.mod (1)
40-40: Verify compatibility with the updated Cosmos SDK version.The version of
github.com/cosmos/cosmos-sdkhas been updated tov0.53.0. Ensure that the updated version is compatible with the other dependencies and the application.simapp/v2/go.mod (1)
37-37: Verify compatibility with the updated Cosmos SDK version.The version of
github.com/cosmos/cosmos-sdkhas been updated tov0.53.0. Ensure that the updated version is compatible with the other dependencies and the application.
4 participants
Description
add backport bot and sims for 52
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Improvements