fix(x/tx): concurrent map writes when calling GetSigners

x/tx/CHANGELOG.md

@@ -33,6 +33,10 @@ Since v0.13.0, x/tx follows Cosmos SDK semver: https://github.com/cosmos/cosmos-
 
 ## [Unreleased]
 
+### Improvements
+
+* [#21073](https://github.com/cosmos/cosmos-sdk/pull/21073) Add write-only mutex in Context to protect `getSignersFuncs` map from concurrent writes.
+
 ## [v0.13.3](https://github.com/cosmos/cosmos-sdk/releases/tag/x/tx/v0.13.3) - 2024-04-22
 
 ### Improvements

x/tx/signing/context.go

@@ -115,6 +115,10 @@ func NewContext(options Options) (*Context, error) {
 		maxRecursionDepth:     options.MaxRecursionDepth,
 	}
 
+	if err := c.Validate(); err != nil {
+		return nil, err
+	}
+
 	return c, nil
 }
 

x/tx/signing/context_test.go

@@ -51,6 +51,33 @@ var deeplyNestedRepeatedSigner = &testpb.DeeplyNestedRepeatedSigner{
 	},
 }
 
+func TestGetGetSignersFnConcurrent(t *testing.T) {
+	ctx, err := NewContext(Options{
+		AddressCodec:          dummyAddressCodec{},
+		ValidatorAddressCodec: dummyValidatorAddressCodec{},
+	})
+	require.NoError(t, err)
+
+	msg := &bankv1beta1.MsgSend{
+		FromAddress: hex.EncodeToString([]byte("foo")),
+	}
+
+	desc := msg.ProtoReflect().Descriptor()
+
+	// err = ctx.Validate()
+	// require.NoError(t, err)
+
+	for i := 0; i < 100; i++ {
+		go func() {
+			_, _ = ctx.getGetSignersFn(desc)
+		}()
+	}
+
+	// signers, err := fn(msg)
+	// require.NoError(t, err)
+	// require.Equal(t, [][]byte{[]byte("foo")}, signers)
+}
+
 func TestGetSigners(t *testing.T) {
 	ctx, err := NewContext(Options{
 		AddressCodec:          dummyAddressCodec{},