Skip to content

R4R: Simulate from a genesis file#3428

Merged
cwgoes merged 7 commits into
developfrom
cwgoes/simulate-from-genesis
Jan 29, 2019
Merged

R4R: Simulate from a genesis file#3428
cwgoes merged 7 commits into
developfrom
cwgoes/simulate-from-genesis

Conversation

@cwgoes

@cwgoes cwgoes commented Jan 29, 2019

Copy link
Copy Markdown
Contributor

Closes #3182

Includes new Makefile commands test_sim_gaia_custom_genesis_fast and test_sim_gaia_custom_genesis_multi_seed, which both default to using ~/.gaiad/config/genesis.json.

To test with the gaia-10k genesis, download this file to ~/.gaiad/config/genesis.json and run one of those new commands.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov

codecov Bot commented Jan 29, 2019

Copy link
Copy Markdown

Codecov Report

Merging #3428 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3428      +/-   ##
===========================================
- Coverage    59.36%   59.34%   -0.03%     
===========================================
  Files          134      134              
  Lines         9972     9972              
===========================================
- Hits          5920     5918       -2     
- Misses        3679     3681       +2     
  Partials       373      373

Comment thread cmd/gaia/app/sim_test.go Outdated
@cwgoes cwgoes changed the title WIP: Simulate from genesis R4R: Simulate from genesis Jan 29, 2019
@cwgoes cwgoes requested a review from zmanian January 29, 2019 19:29
@cwgoes cwgoes changed the title R4R: Simulate from genesis R4R: Simulate from a genesis file Jan 29, 2019
Comment thread Makefile Outdated

@rigelrozanski rigelrozanski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - few comments to address within

Comment thread Makefile
Comment thread cmd/gaia/app/sim_test.go Outdated
Comment thread cmd/gaia/app/sim_test.go Outdated
Comment thread cmd/gaia/app/sim_test.go
Comment thread x/mock/simulation/simulate.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants