Config params not properly parsed

[mpoke]

Summary of Bug

Configuration params with the key = [ ] structure are not properly passed. The expected value should be an empty list, however, the outcome is a nil value.

In general, we should be able to differentiate between the following scenarios:

• no key in the config file
  • Log that default value is used instead
• key =
  • Log a warning that the config is incorrect. Use default value instead.
• key = [ ]
  • The value for the key is an empty list
• key = ["value1", "value2"]
  • The value for the key is this list.

Version

v8, v9

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned
• Is a spike necessary to map out how the issue should be approached?

[mpoke]

Note that a fix for this issue would not be state breaking. Thus, it can be applied after releasing v8 and v9.

[ancazamfir]

I am ok with what you decide wrt to timeline. But I think for v8 we should document things clearly.

regarding the issue itself, why is the default set to those IBC messages?

bypass-min-fee-msg-types = ["/ibc.core.channel.v1.MsgRecvPacket", "/ibc.core.channel.v1.MsgAcknowledgement", "/ibc.core.client.v1.MsgUpdateClient", ]

imho it should be [].

The current default is not clearly stated in the app.toml comments. I was testing this and assumed that if I removed the bypass-min-fee-msg-types there will be no bypassing. The comments should be updated.

The list is also incomplete from packet relaying pov, should also contain the timeout message types (there are two /ibc.core.client.v1.MsgTimeout and /ibc.core.client.v1.MsgTimeoutOnClose).

The format of these strings requires operators to have intimate knowledge of protobuf Any Uris for IBC messages. There should be some documentation available and kept up to date for these.