fix: ledger signing on macOS #2763
Merged
Merged
Conversation
c1c5caf to
11c731c
Compare
|
Got signature issue on Linux and solved my issue with this fix as well |
MSalopek
approved these changes
Oct 30, 2023
MSalopek
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution.
Approve!
mmulji-ic
approved these changes
Oct 31, 2023
mergify Bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
(cherry picked from commit b11af5a)
p-offtermatt
pushed a commit
that referenced
this pull request
Nov 1, 2023
12 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Newest versions of macOS and Xcode seems to have moved a few things and signing with ledger through the binary will not work with them.
This PR bumps hid and ledger-cosmos deps that include the fix.
See:
Zondax/hid#15
cosmos/ledger-cosmos#101
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog(for details, see contributing guidelines)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change