chore!: migrate escrow accounts#2993
Merged
Merged
Conversation
sainoe
requested review from
alexanderbez,
crodriguezvega,
jackzampolin and
zmanian
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
394
to
414
Check warning
Code scanning / CodeQL
Iteration over map
mpoke
reviewed
Mar 12, 2024
mpoke
left a comment
mpoke
left a comment
Contributor
There was a problem hiding this comment.
Please rebase on main and add label to backport to v15.1.x. Also, see my comments below.
sainoe
force-pushed
the
sainoe/migrate-escrow-accounts
branch
from
bf5bed2 to
d064275
Compare
* Add UT for escrow accounts migration * Add changelog entry * Address comments and fix test issue
sainoe
force-pushed
the
sainoe/migrate-escrow-accounts
branch
from
d064275 to
5ad7047
Compare
mpoke
approved these changes
Mar 12, 2024
MSalopek
approved these changes
Mar 13, 2024
| // to be represented using an 64-bit integer. Therefore, it's added to the | ||
| // escrow updates list under the condition that the amount is successfully | ||
| // converted to the sdk.Int type. | ||
| if amt, ok := sdk.NewIntFromString("4388000000000000000000"); !ok { |
Contributor
There was a problem hiding this comment.
Unfortunately there isn't a sdk.MustNewIntFromString function so this will do.
mergify Bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Add UT for escrow accounts migration * Add changelog entry * Address comments and fix test issue (cherry picked from commit d8d90cc)
18 tasks
sainoe
added a commit
that referenced
this pull request
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #2989
cc @jtieri
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog(for details, see contributing guidelines)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change