Skip to content

fix!: update gov MaxMetadataLen#3025

Merged
MSalopek merged 2 commits into
cosmos:mainfrom
doggystylez:fix-metadatalen
Mar 29, 2024
Merged

fix!: update gov MaxMetadataLen#3025
MSalopek merged 2 commits into
cosmos:mainfrom
doggystylez:fix-metadatalen

Conversation

@doggystylez

@doggystylez doggystylez commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

Description

Closes: #XXXX

in the recent sdk version upgrade, the metadeta length for gov props was set to default 255, which affects the description field for legacy (and new?) proposals. see:

https://www.mintscan.io/cosmos/proposals/893
https://www.mintscan.io/cosmos/proposals/895


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@doggystylez doggystylez requested a review from a team March 26, 2024 11:17
@doggystylez doggystylez changed the title fix: update gov MaxMetadataLen fix!: update gov MaxMetadataLen Mar 26, 2024

@MSalopek MSalopek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Could you link to the code line that defined this value in old gaia versions (or cosmos-sdk versions)?

On v47 it seems that all text fields are subject to the same assertions which may be a bit too strict:

Providing more context:

On cosmos-sdk v0.47 you can submit text proposals via gaiad tx gov submit-legacy-proposal (the "old" text proposals) and via gaiad tx gov submit-proposal.

Both ways of submitting proposals are affected.

@MSalopek MSalopek self-assigned this Mar 28, 2024
@MSalopek MSalopek added A:backport/v15.1.x type: bug Issues that need priority attention -- something isn't working scope: cosmos-sdk Integration with Cosmos SDK and removed A:backport/v15.1.x labels Mar 28, 2024
@MSalopek MSalopek merged commit c908e4b into cosmos:main Mar 29, 2024
mergify Bot pushed a commit that referenced this pull request Mar 29, 2024
Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
(cherry picked from commit c908e4b)
MSalopek pushed a commit that referenced this pull request Mar 29, 2024
Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
(cherry picked from commit c908e4b)

Co-authored-by: doggystylez <98429202+doggystylez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: cosmos-sdk Integration with Cosmos SDK type: bug Issues that need priority attention -- something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants