feat!: add upgrade handler for initializing ICS epochs#3079
Merged
Conversation
mpoke
requested review from
alexanderbez,
crodriguezvega,
jackzampolin and
zmanian
as code owners
mpoke
changed the title
p-offtermatt
approved these changes
Apr 23, 2024
p-offtermatt
left a comment
p-offtermatt
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thank you!
Contributor
|
LGTM! Well done. |
sainoe
approved these changes
Apr 23, 2024
mergify Bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
* add upgrade handler for initializing ICS epochs * adding changelog entries * fix test (cherry picked from commit 5c5447c) # Conflicts: # .changelog/v16.0.0/dependencies/3079-init-ics-epochs.md # .changelog/v16.0.0/features/3079-init-ics-epochs.md
18 tasks
mpoke
added a commit
that referenced
this pull request
Apr 23, 2024
… (#3080) * feat!: add upgrade handler for initializing ICS epochs (#3079) * add upgrade handler for initializing ICS epochs * adding changelog entries * fix test (cherry picked from commit 5c5447c) # Conflicts: # .changelog/v16.0.0/dependencies/3079-init-ics-epochs.md # .changelog/v16.0.0/features/3079-init-ics-epochs.md * fixing changelog --------- Co-authored-by: Marius Poke <marius.poke@posteo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Add the initial consumer validator sets for all consumer chains. This is needed by ICS epochs.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog(for details, see contributing guidelines)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change