Skip to content

feat!: bump ICS to v4.2.0-lsm#3103

Merged
mpoke merged 2 commits into
mainfrom
marius/bump-ics
May 17, 2024
Merged

feat!: bump ICS to v4.2.0-lsm#3103
mpoke merged 2 commits into
mainfrom
marius/bump-ics

Conversation

@mpoke

@mpoke mpoke commented May 17, 2024

Copy link
Copy Markdown
Contributor

Description

Closes: #XXXX

Add PSS to Gaia -- bumps ICS to https://github.com/cosmos/interchain-security/releases/tag/v4.2.0-lsm


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@p-offtermatt

Copy link
Copy Markdown
Contributor

Do we need a changelog entry for the minor cometbft bump?

@mpoke

mpoke commented May 17, 2024

Copy link
Copy Markdown
Contributor Author

Do we need a changelog entry for the minor cometbft bump?

This PR doesn't bump Comet. The current version of Comet was upgraded in v16.0.0 and the changelog is there https://github.com/cosmos/gaia/blob/main/CHANGELOG.md#dependencies

@mpoke mpoke merged commit 2f00c60 into main May 17, 2024
@mpoke mpoke deleted the marius/bump-ics branch May 17, 2024 15:10
mergify Bot pushed a commit that referenced this pull request May 17, 2024
* bump ICS to v4.2.0-lsm

* add changelog entries

(cherry picked from commit 2f00c60)
mpoke added a commit that referenced this pull request May 17, 2024
* feat!: bump ICS to v4.2.0-lsm (#3103)

* bump ICS to v4.2.0-lsm

* add changelog entries

(cherry picked from commit 2f00c60)

* update changelog entries

---------

Co-authored-by: Marius Poke <marius.poke@posteo.de>
@mpoke

mpoke commented May 17, 2024

Copy link
Copy Markdown
Contributor Author

Do we need a changelog entry for the minor cometbft bump?

This PR doesn't bump Comet. The current version of Comet was upgraded in v16.0.0 and the changelog is there https://github.com/cosmos/gaia/blob/main/CHANGELOG.md#dependencies

Actually you are right. I added it in the release branch and then we are going to bring it to main anyway #3104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants