feat!: add expedited propsals support#3149
Merged
Merged
Conversation
Contributor
Author
|
Also requires changes to ICS to support the new changes in gov. |
MSalopek
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
Also requires forking wasmd and supporting the correct gov interface. |
MSalopek
requested review from
crodriguezvega,
jackzampolin and
zmanian
as code owners
8 tasks
mpoke
reviewed
Jun 21, 2024
mpoke
left a comment
mpoke
left a comment
Contributor
There was a problem hiding this comment.
The general logic LGTM. The params are not initialized with the values from the proposal.
|
|
||
| // Use special SDK v0.47.x release with support for both ICS and LSM | ||
| github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.47.15-ics-lsm | ||
| github.com/cosmos/cosmos-sdk => github.com/informalsystems/cosmos-sdk v0.46.0-alpha2.0.20240614081903-f1b9aac8d413 |
Contributor
There was a problem hiding this comment.
Why are we using a spacial 0.46 branch of SDK?
Contributor
There was a problem hiding this comment.
Why is this under API breaking?
Contributor
Author
There was a problem hiding this comment.
Adds a new API method.
| govParams := keepers.GovKeeper.GetParams(ctx) | ||
| govParams.ExpeditedVotingPeriod = &expeditedPeriod | ||
| govParams.ExpeditedThreshold = govv1.DefaultExpeditedThreshold.String() // 66.7% | ||
| govParams.ExpeditedMinDeposit = govParams.MinDeposit // full deposit amount is required |
Contributor
There was a problem hiding this comment.
This needs to be 500 ATOMs. The min deposit is 250 ATOMs. See https://www.mintscan.io/cosmos/proposals/926
mpoke
approved these changes
Jun 21, 2024
dusan-maksimovic
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add expedited proposals to gaia v18.
Related:
Uses: