fix: reintroduce gaia docker builds#3199
Conversation
This is for compatibility with interchaintest, since it will chown files to that UID/GUID
They execute on the main branch, releases, and on workflow dispatch. Also get rid of the Dockerfile and use just the e2e one
fastfadingviolets
force-pushed
the
docker-build
branch
from
3fc0afb to
1cbe5ca
Compare
|
On the |
fastfadingviolets
force-pushed
the
docker-build
branch
from
08ddc42 to
903df4c
Compare
fastfadingviolets
changed the title
fastfadingviolets
requested review from
crodriguezvega,
jackzampolin and
zmanian
as code owners
There was a problem hiding this comment.
Thank you for your contribution!
I think we can merge this, I would like us to switch to using a file named Dockerfile and changing the docker-push workflow fto a nightly build - main is quite noisy and gets multiple pushes a day which are not all required to produce working binaries at all times.
Something like this, maybe? We can have a separate workflow for nightly and release builds, it does not make much of a difference.
EDIT:
Suggestions are nice to haves, they are not merge blocking.
|
Thanks for your comments! I addressed them, plus added a short |
fastfadingviolets
force-pushed
the
docker-build
branch
from
a986d66 to
1e6e363
Compare
Awesome! Thank you very much for this! |
MSalopek
left a comment
MSalopek
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for the changes!
* Set UID and GUID to 1025 in Dockerfile This is for compatibility with interchaintest, since it will chown files to that UID/GUID * Reenable docker builds. They execute on the main branch, releases, and on workflow dispatch. Also get rid of the Dockerfile and use just the e2e one * add changelog entry * Only run docker build on GIT_DIFF * Nightly docker builds, plus add a DOCKER_README
3 participants
Description
Closes: #3124
Brings back the docker-push workflow to build a docker image for gaia. Gets rid of the
Dockerfile, and uses only thee2e.Dockerfile.Also changes the UID/GUID of the user in the docker image to be1025, which makes it compatible with interchaintestAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog(for details, see contributing guidelines)