chore(any): Add cosmos any type#115
Merged
Merged
Conversation
Remove sdk dependencies
julienrbrt
reviewed
Mar 15, 2024
julienrbrt
left a comment
julienrbrt
left a comment
Contributor
There was a problem hiding this comment.
lgtm, just changelog for this addition and the go mod bump needed
julienrbrt
reviewed
Mar 15, 2024
Trim down interface_registry
julienrbrt
reviewed
Mar 16, 2024
kocubinski
reviewed
Mar 18, 2024
tac0turtle
reviewed
Mar 19, 2024
tac0turtle
left a comment
tac0turtle
left a comment
Contributor
There was a problem hiding this comment.
looks good, reverting the go mod change then it should be good
Updated changelog
Contributor
Author
ok, go bump reverted 👍🏻 |
tac0turtle
approved these changes
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the dependence on cosmos-sdk/codec/types
Partially closes cosmos/cosmos-sdk#19446