fix: fix make regenerate#14
Merged
Merged
Conversation
julienrbrt
force-pushed
the
julien/fix-make-renegate
branch
from
2476661 to
c74d43c
Compare
julienrbrt
force-pushed
the
julien/fix-make-renegate
branch
from
e6bb060 to
f9e5895
Compare
julienrbrt
force-pushed
the
julien/fix-make-renegate
branch
from
f9e5895 to
cc0ce09
Compare
Closed
tac0turtle
approved these changes
Oct 25, 2022
tac0turtle
left a comment
tac0turtle
left a comment
Contributor
There was a problem hiding this comment.
gonna approve since the size of the pr is massive and its fixing tests and some formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make renegerate(Closesmake regenerateis broken #10)After this PR is merged, the newly added GH workflow, will be set as required.
There is a flaky test in
gogo/protobufthat is caught by CI. I have ignored it.