fix: fix CompactTextString panics with nested Anys and private fields#24
Merged
Conversation
robert-zaremba
left a comment
robert-zaremba
left a comment
Contributor
There was a problem hiding this comment.
Let's check if we need to handle bool type as well.
julienrbrt
changed the title
julienrbrt
changed the title
CompactTextString panics with nested Anys and private fields
This was referenced Nov 12, 2022
tac0turtle
approved these changes
Nov 14, 2022
odeke-em
reviewed
Nov 25, 2022
| >` | ||
| got := proto.MarshalTextString(m) | ||
| if strings.EqualFold(expected, got) { | ||
| t.Errorf("got = %s, want %s", expected, got) |
There was a problem hiding this comment.
Invalid order of the error log; got should be first then expected :-) Also this test is saying that the values match with the same case then error out, did you mean if !strings.EqualFold?
Contributor
Author
There was a problem hiding this comment.
You are right, actually the test is not so useful either tbh (and wrong as you've noticed).
I have tested the fix using replace in the SDK directly, and quickly wrong this without paying too much attention :/ I can fix it or just remove it 🤷🏾♂️
There was a problem hiding this comment.
Please fix it :-) I am up and will gladly review it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes cosmos/cosmos-sdk#10965.
Looking at the tests now. Using a
replacein the Cosmos SDK resolves cosmos/cosmos-sdk#10965 and cosmos/cosmos-sdk#13838 (using the codegen String method)We'll need to tag
1.4.3after.