Skip to content

chore: remove double registration warning#67

Merged
julienrbrt merged 2 commits into
mainfrom
julien/remove-warning
May 11, 2023
Merged

chore: remove double registration warning#67
julienrbrt merged 2 commits into
mainfrom
julien/remove-warning

Conversation

@julienrbrt

Copy link
Copy Markdown
Contributor

@julienrbrt julienrbrt requested a review from a team May 11, 2023 10:01
@julienrbrt julienrbrt marked this pull request as draft May 11, 2023 10:09
@julienrbrt julienrbrt marked this pull request as ready for review May 11, 2023 10:37
@julienrbrt julienrbrt requested a review from tac0turtle May 11, 2023 11:57
@julienrbrt julienrbrt linked an issue May 11, 2023 that may be closed by this pull request

@aaronc aaronc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay approving this, but I'm not sure it's not useful for other cases. But probably fine unless we hit an issue

@julienrbrt

Copy link
Copy Markdown
Contributor Author

I'm okay approving this, but I'm not sure it's not useful for other cases. But probably fine unless we hit an issue

I was thinking of passing a logger but that was more breaking.
Do you think it is worth it?

@julienrbrt julienrbrt merged commit 28c37ed into main May 11, 2023
@julienrbrt julienrbrt deleted the julien/remove-warning branch May 11, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

New warnings with v1.4.9 proto: file "google/protobuf/any.proto" already registered

2 participants