feat: cherry-pick improvements from gogo/protobuf#8
Merged
Conversation
Contributor
|
@julienrbrt yes it worked. I was able to generate all the files. But I had to make many changes. See my commits. |
robert-zaremba
approved these changes
Sep 1, 2022
robert-zaremba
left a comment
robert-zaremba
left a comment
Contributor
There was a problem hiding this comment.
utACK, left few comments
Contributor
Author
Okay, I'll submit an issue to fix them then, and I'll look at it later. |
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick:
I tried to fix the
make regeneratewithout too much success (although I have not looked at it very long).@robert-zaremba has it ever worked?