Upgrade to fast IAVL with multi batches#531
Conversation
| "github.com/cosmos/iavl/internal/logger" | ||
| ) | ||
|
|
||
| var commitGap uint64 = 10000000 |
There was a problem hiding this comment.
let's add a comment here
There was a problem hiding this comment.
have you tried different numbers to see results?
There was a problem hiding this comment.
have you tried different numbers to see results?
not yet. maybe I can use a different value to comare with this. do you have any sugguestion? maybe 5,000,000?
There was a problem hiding this comment.
amazing, lets run with it, thank you for doing the research
There was a problem hiding this comment.
ok, had change the commitGap to 5000000, and remove the timing-gc related code.
|
very interesting! |
|
@p0mvn you have been in charge for the fast cache - would you have time to review this PR? |
p0mvn
left a comment
There was a problem hiding this comment.
utACK.
Thank you for this change. That makes sense.
As a side note for future work, do you think we can now remove this garbage collection logic:
Lines 688 to 712 in 807f8c5
That logic was added to mitigate OOM but I think the solution in this PR might remove the need for the garbage collection.
We suspect that this garbage collection might be increasing the setup time in our unit tests in Osmosis.
@p0mvn I do upgrade comparison on our aws machine( data set four ways to upgrade
I got the two conclusion:
|
…ding to fast IAVL
tac0turtle
left a comment
There was a problem hiding this comment.
thank you for this pr


When we auto upgrade our huge (289G) data. We met OOM. so splite to multi batches to upgrade the fast storage.