fix: commit the ndb in LoadVersionForOverwriting#640
Merged
Conversation
yihuang
commented
Dec 4, 2022
cool-develope
approved these changes
Dec 5, 2022
Contributor
|
was this a regression or a new change? |
Author
it's a bug fix I believe. |
yihuang
commented
Dec 6, 2022
Contributor
|
should we backport this to 0.19? |
Author
I think so |
Contributor
|
amazing I will test on a chain before final release |
Contributor
|
@Mergifyio backport release/v0.19.x |
mergify Bot
pushed a commit
that referenced
this pull request
Dec 7, 2022
(cherry picked from commit e144f08) # Conflicts: # CHANGELOG.md
Contributor
✅ Backports have been createdDetails
|
tac0turtle
added a commit
that referenced
this pull request
Dec 7, 2022
13 tasks
ankurdotb
pushed a commit
to cheqd/iavl
that referenced
this pull request
Feb 28, 2023
cosmos#643) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Marko <marbar3778@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
need to backport to 0.19.x.
It was previously included in #636, separate out for easier review.