feat: decouple cosmos-db by cool-develope · Pull Request #874 · cosmos/iavl

cool-develope · 2024-01-22T14:05:31Z

Context

As discussed in this, we need to decouple cosmos-db from iavl.

Implemented the own raw DB interface
Added the Wrapper to support the old clients which use cosmos-db
cleanup
updated golangci-lint from 1.51.2 to 1.55.2 ref

coderabbitai · 2024-01-22T14:05:57Z

Warning

Rate Limit Exceeded

@cool-develope has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 0 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 98d5ede and 003b801.

Walkthrough

The overarching change involves a refactor of the database interaction within a codebase, primarily affecting import paths, function calls, and type definitions. The db package has been renamed to dbm, and a new in-memory database backend using a B-tree has been introduced. A Wrapper type has also been added to implement the DB interface. Additionally, there are updates to how database backends are interacted with, including changes to backend types and iterators.

Changes

Files	Change Summary
`basic_test.go`, `batch.go`, `batch_test.go`, `benchmarks/bench_test.go`, `benchmarks/cosmos-exim/main.go`, `cmd/iaviewer/main.go`, `diff_test.go`, `export_test.go`, `import_test.go`, `iterator_test.go`, `migrate_test.go`, `mock/db_mock.go`, `mutable_tree.go`, `mutable_tree_test.go`, `nodedb.go`, `nodedb_test.go`, `proof_iavl_test.go`, `proof_ics23_test.go`, `testutils_test.go`, `tree_random_test.go`, `tree_test.go`	Updated import paths from `github.com/cosmos/cosmos-db` to `github.com/cosmos/iavl/db`. Refactored `db.NewMemDB()` to `dbm.NewMemDB()` and `db.NewDB` to `dbm.NewDB`. Adjusted function signatures and calls to use new `dbm` types and methods.
`db/memdb.go`, `db/types.go`, `db/wrapper.go`	Introduced new `MemDB` backend, `DB` interface, and `Wrapper` type.
`internal/bytes/bytes.go`	Added new functions `Cp` and `CpIncr`.
`.github/workflows/lint.yml`, `Makefile`	Updated tool versions for linting.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai · 2024-01-22T14:14:28Z

 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"

-	db "github.com/cosmos/cosmos-db"
+	dbm "github.com/cosmos/iavl/db"
 )

 var (


📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [12-12]

The FIXME comment indicates that maxIterator should be enlarged to 100000. This should be addressed or tracked in an issue for future improvement.

Would you like me to open a GitHub issue to track this task?

alexanderbez

nit: I would put all DB types into public const.

cool-develope · 2024-01-25T17:49:28Z

@tac0turtle backport to v1.0.x?

alexanderbez · 2024-02-20T17:10:43Z

@Mergifyio backport release/v1.x.x

mergify · 2024-02-20T17:11:02Z

backport release/v1.x.x

✅ Backports have been created

Details

#887 feat: decouple cosmos-db (backport #874) has been created for branch release/v1.x.x but encountered conflicts

(cherry picked from commit 11ba496) # Conflicts: # .github/workflows/lint.yml # batch.go # nodedb.go

Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com> Co-authored-by: Cool Developer <cool199966@outlook.com>

This reverts commit e019f74.

decouple cosmos-db

38fd6f2

cool-develope requested a review from a team January 22, 2024 14:05

coderabbitai Bot reviewed Jan 22, 2024

View reviewed changes

cool-develope requested a review from alexanderbez January 24, 2024 15:11

alexanderbez approved these changes Jan 24, 2024

View reviewed changes

alexanderbez requested review from kocubinski and tac0turtle January 24, 2024 17:29

cool-develope mentioned this pull request Jan 25, 2024

feat(store/v2): remove cosmos-db depdency from store cosmos/cosmos-sdk#19229

Merged

12 tasks

tac0turtle approved these changes Jan 25, 2024

View reviewed changes

Comment thread db/memdb.go Outdated

Comment thread nodedb.go Outdated

cool-develope added 3 commits January 25, 2024 12:11

linting

98d5ede

fix linting

7b0b23e

fix linting

003b801

cool-develope merged commit 11ba496 into master Jan 25, 2024

cool-develope deleted the feat/cosmos-db branch January 25, 2024 17:49

alexanderbez added the backport/v1.x label Feb 20, 2024

mergify Bot pushed a commit that referenced this pull request Feb 20, 2024

feat: decouple cosmos-db (#874)

192accd

(cherry picked from commit 11ba496) # Conflicts: # .github/workflows/lint.yml # batch.go # nodedb.go

mergify Bot mentioned this pull request Feb 20, 2024

feat: decouple cosmos-db (backport #874) #887

Merged

alexanderbez pushed a commit that referenced this pull request Feb 21, 2024

feat: decouple cosmos-db (backport #874) (#887)

e019f74

Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com> Co-authored-by: Cool Developer <cool199966@outlook.com>

cool-develope mentioned this pull request Feb 22, 2024

chore(docs): add documents of db #888

Merged

tac0turtle added a commit that referenced this pull request Mar 6, 2024

Revert "feat: decouple cosmos-db (backport #874) (#887)"

f9e0be0

This reverts commit e019f74.

coderabbitai Bot mentioned this pull request May 13, 2024

chore: changelog onto master #946

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: decouple cosmos-db#874

feat: decouple cosmos-db#874
cool-develope merged 4 commits into
masterfrom
feat/cosmos-db

cool-develope commented Jan 22, 2024 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jan 22, 2024 •

edited

Loading

Rate Limit Exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

Uh oh!

coderabbitai Bot Jan 22, 2024

Uh oh!

alexanderbez left a comment

Uh oh!

Uh oh!

Uh oh!

cool-develope commented Jan 25, 2024

Uh oh!

alexanderbez commented Feb 20, 2024

Uh oh!

mergify Bot commented Feb 20, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

cool-develope commented Jan 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Uh oh!

coderabbitai Bot commented Jan 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate Limit Exceeded

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

Uh oh!

coderabbitai Bot Jan 22, 2024

Choose a reason for hiding this comment

Uh oh!

alexanderbez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cool-develope commented Jan 25, 2024

Uh oh!

alexanderbez commented Feb 20, 2024

Uh oh!

mergify Bot commented Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

cool-develope commented Jan 22, 2024 •

edited

Loading

coderabbitai Bot commented Jan 22, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

mergify Bot commented Feb 20, 2024 •

edited

Loading