Skip to content

Fix for native navigation #233

Merged
cranci1 merged 8 commits intocranci1:devfrom
Ek20000:dev
Aug 15, 2025
Merged

Fix for native navigation #233
cranci1 merged 8 commits intocranci1:devfrom
Ek20000:dev

Conversation

@Ek20000
Copy link
Copy Markdown
Contributor

@Ek20000 Ek20000 commented Aug 14, 2025

Due to the lack of a search bar, the native tab bar is currently not usable. I added a custom searchbar, which does not use the .searchable in the TabView. It would be awesome to someday use the .searchable Tab with the dedicated search button, but for some reason that does not work. Use this as a workaround maybe, just for the sake of being able to use the native tab bar.

Bildschirmfoto 2025-08-14 um 16 06 30

@cranci1
Copy link
Copy Markdown
Owner

cranci1 commented Aug 14, 2025

Oh wait, I think it's my fault if the build is failing, give me a second. Also thanks a lot for the help!

@cranci1
Copy link
Copy Markdown
Owner

cranci1 commented Aug 14, 2025

Yeah i see the issue now. Github doesn't have iOS 18 sdk installed on the machines, kinda weird.

@Ek20000
Copy link
Copy Markdown
Contributor Author

Ek20000 commented Aug 14, 2025

Yeah no worries. I also tried to fix the issue with the locked scroll if you scroll to the bottom of ep list. It is a bit janky but it somehow scrolls now :)

@cranci1
Copy link
Copy Markdown
Owner

cranci1 commented Aug 15, 2025

Alright I should have fixed the build script let's see

@cranci1
Copy link
Copy Markdown
Owner

cranci1 commented Aug 15, 2025

Looking very good man!! Thanks a lot <3

@cranci1 cranci1 merged commit 122e248 into cranci1:dev Aug 15, 2025
2 checks passed
@Ek20000
Copy link
Copy Markdown
Contributor Author

Ek20000 commented Aug 15, 2025

Happy to help. Next thing I can look into is chromecast. I got a version running a few weeks ago, but I never commited it. I need chromecast to work for me haha

@cranci1
Copy link
Copy Markdown
Owner

cranci1 commented Aug 15, 2025

Oh btw just so you know, this version of Sora wont be updated anymore, I'm building a new version from ground on the new repo: Sora-2 where I plan to add chromecast support so you might want to look there.

@Ek20000
Copy link
Copy Markdown
Contributor Author

Ek20000 commented Aug 15, 2025

Oh btw just so you know, this version of Sora wont be updated anymore, I'm building a new version from ground on the new repo: Sora-2 where I plan to add chromecast support so you might want to look there.

ohh nice, I might take a look into that, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants