IG crash on launch (3.5.0-dev.5)

[bzra]

--- Device Info ---
Brand: samsung
OS Version: 16
SDK Level: 36

--- App Info ---
Package Name: com.instagram.android
Version Name: 430.0.0.53.80
Version Code: 2147483647

--- Stack Trace ---
java.lang.RuntimeException: Unable to start activity ComponentInfo{com.instagram.android/com.instagram.mainactivity.InstagramMainActivity}
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:5040)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:5290)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:224)
at android.app.servertransaction.TransactionExecutor.executeNonLifecycleItem(TransactionExecutor.java:133)
at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:103)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:80)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:3287)
at X.00ww.A00(:13)
at X.0888.A9Z(Unknown Source:36)
at X.00ww.handleMessage(:37)
at android.os.Handler.dispatchMessage(Handler.java:128)
at android.os.Looper.dispatchMessage(Looper.java:358)
at android.os.Looper.loopOnce(Looper.java:288)
at android.os.Looper.loop(Looper.java:392)
at android.app.ActivityThread.main(ActivityThread.java:10346)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:638)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:972)
Caused by: java.lang.UnsupportedOperationException: remove
at java.util.Iterator.remove(Iterator.java:102)
at app.morphe.extension.instagram.patches.hide.navigation.HideNavigationButtonsPatch.filterNavigationButtons(HideNavigationButtonsPatch.java:58)
at X.00TJ.A04(Unknown Source:8)
at X.00TI.(Unknown Source:40)
at com.instagram.mainactivity.InstagramMainActivity.A0i(:82383)
at com.instagram.mainactivity.InstagramMainActivity.A1q(:20)
at X.00MX.Eln(Unknown Source:2)
at X.09kr.A00(Unknown Source:23)
at X.09kr.invoke(Unknown Source:5)
at X.00MZ.A00(Unknown Source:141)
at com.instagram.base.activity.IgFragmentActivity.onCreate(Unknown Source:28)
at com.instagram.base.activity.BaseFragmentActivity.onCreate(Unknown Source:7)
at android.app.Activity.performCreate(Activity.java:9753)
at android.app.Activity.performCreate(Activity.java:9722)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1544)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:5024)
... 17 more

Re-patching with Hide Navigation Buttons patch disabled prevents the crash on launch.

[nick490u8585]

For some reason it doesn't crash on gos. Cannot replicate issue

[swakwork]

@bzra Are you using it on a tablet ?

[bzra]

@swakwork : Yes, I am. It's a Samsung Tab S9 Ultra (SM-x910)

[swakwork]

It crashes on mine as well, I thought most wouldn't be using it on tablets, so kept it as it is as it's working fine on phones.
Remove the Hide Navigation Buttons patch for now if you are on tablet

[RenegadeGee]

How would I get the info above? I've been having the same issue on my S24+ and I tried repatching with Hide navigation buttons disabled but the same issue occurs. I'm running on stable release and have tried the experimental version but same issue.

[swakwork]

I tried repatching with Hide navigation buttons disabled but the same issue occurs.

Then the issue might be something else

[swakwork]

Re-patching with Hide Navigation Buttons patch disabled prevents the crash on launch.

@brosssh looks like hide navigation buttons is broken for phones/tablets with higher DPI. When you get time can you look into it ?
To reproduce the issue, try settings your phone DPI to 711 (that's my tablet's DPI), it should trigger the tablet Instagram UI and then crash

[brosssh]

With the stacktrace the error is clear, someone reported it already to me but couldn't provide the stacktrace. The list is immutable for tablet version, so the solution is to clone it and then modify the cloned list inside the extension. I'll implement this later.

[brosssh]

I've released a possible fix in my repo. To test it, download the .mpp file from here, add it to morphe manager as a local source, repatch and enable the Hide navigation buttons patch in this bundle (also disable the patch in Piko source).

Report back it the app works, the reel button should be hidden.

[bzra]

I'll test this when I get home from work later 👍🏻

[RenegadeGee]

I've released a possible fix in my repo. To test it, download the .mpp file from here, add it to morphe manager as a local source, repatch and enable the Hide navigation buttons patch in this bundle (also disable the patch in Piko source).

Report back it the app works, the reel button should be hidden.

I tested just yout patches alone and the home page doesn't seem to load now

[brosssh]

You enabled the hide feed patch. My repo goal are different from piko one, I aim at distraction-free Instagram, select only the patches which you really want.

Anyway, since it didn't crash I assume my fix is working. Is the reel button hidden?

[RenegadeGee]

app.morphe.patcher.patch.PatchException: List contains no element matching the predicate.
at app.morphe.patcher.Patcher$invoke$1.invokeSuspend$execute(SourceFile:102)
at app.morphe.patcher.Patcher$invoke$1.invokeSuspend(SourceFile:120)
at app.morphe.patcher.Patcher$invoke$1.invoke(SourceFile:0)
at app.morphe.patcher.Patcher$invoke$1.invoke(SourceFile:0)
at kotlinx.coroutines.flow.SafeFlow.collectSafely(SourceFile:57)
at kotlinx.coroutines.flow.AbstractFlow.collect(SourceFile:226)
at app.morphe.manager.patcher.Session.applyPatchesVerbose(SourceFile:50)
at app.morphe.manager.patcher.Session.run(SourceFile:96)
at app.morphe.manager.patcher.runtime.process.PatcherProcess$start$1.invokeSuspend(SourceFile:117)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(SourceFile:34)
at kotlinx.coroutines.DispatchedTask.run(SourceFile:100)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(SourceFile:586)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(SourceFile:829)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(SourceFile:717)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(SourceFile:704)
Caused by: java.util.NoSuchElementException: List contains no element matching the predicate.
at app.crimera.patches.instagram.misc.download.DownloadMediaPatchKt.downloadMediaPatch$lambda$12$lambda$11(DownloadMediaPatch.kt:174)
at app.crimera.patches.instagram.misc.download.DownloadMediaPatchKt.$r8$lambda$fI7bZaboD67_PC8IszCp-0Gdack(DownloadMediaPatch.kt:0)
at app.crimera.patches.instagram.misc.download.DownloadMediaPatchKt$$ExternalSyntheticLambda0.invoke(D8$$SyntheticClass:0)
at app.morphe.patcher.patch.Patch.execute(SourceFile:126)
at app.morphe.patcher.patch.BytecodePatch.execute$morphe_patcher(SourceFile:241)
at app.morphe.patcher.Patcher$invoke$1.invokeSuspend$execute(SourceFile:96)
... 14 more

So I tried your patch for Hide navigation buttons only and enabled the rest of piko patches on both version 423.0.0.47.66 and 430.0.0.53.80. On 430 the patcher fails and on 423 it instagram loads but still crashes. When I was patching 430 the error above is what I got.

[brosssh]

That's unrelated, caused by:

app.crimera.patches.instagram.misc.download.DownloadMediaPatchKt.downloadMediaPatch

@swakwork you know why?

[Swakshan]

That's unrelated, caused by:

app.crimera.patches.instagram.misc.download.DownloadMediaPatchKt.downloadMediaPatch

@swakwork you know why?

Fingerprint mismatch, possibly due to patching with unsupported version code