Add --force-non-host flag.

[reitermarkus]

Closes #536.

[Dylan-DPC-zz]

bors: r+

[bors]

Build failed:

• rust-embedded.cross

[reitermarkus]

bors retry

[bors]

Build failed:

• rust-embedded.cross

[reitermarkus]

@rbtcollins, rustup toolchain install doesn't seem to have this option and cross doesn't call rustup update anywhere.

[Emilgardis]

just a small nitpick, should this be backported into https://github.com/rust-embedded/cross/tree/v0.2.1 ?

[rbtcollins]

Hmmmm, will look into that. Internally the two are basically aliases.

[Emilgardis]

What's the status on this? @rbtcollins

[rbtcollins]

We added the flag to rustup, and its in a deprecation period where it isn't required. I encourage merging the use of the flag, so that we can move forward with making it required.

There is a UI glitch associated with it triggering unnecessarily in some cases on Windows, but we should get that fixed for the next release I hope

[Emilgardis]

bors retry

[bors]

Build failed:

• rust-embedded.cross

[adamgreig]

It looks like this is failing on MacOS and Windows builds with:

+ cross check --target x86_64-apple-darwin
error: Found argument '--force-non-host' which wasn't expected, or isn't valid in this context
	Did you mean --force?

USAGE:
    rustup toolchain install <toolchain>... --force

For more information try --help
error: couldn't install toolchain `1.42.0-x86_64-unknown-linux-gnu`
caused by: `"rustup" "toolchain" "install" "--force-non-host" "1.42.0-x86_64-unknown-linux-gnu"` failed with exit code: Some(1)
note: run with `RUST_BACKTRACE=1` for a backtrace

i.e., related to adding --force-non-host, any ideas?

[reitermarkus]

We added the flag to rustup, and its in a deprecation period where it isn't required.

@rbtcollins, rustup toolchain install still doesn't accept this flag.

[Emilgardis]

rust-lang/rustup#2968 has been merged, not sure when next release is

[otavio]

As rustup has support for it, are this going in 0.2.2?

[Emilgardis]

As rustup has support for it, are this going in 0.2.2?

this issue is blocked on new rustup release, it can't be included without upstream support

[Alexhuszagh]

As rustup has support for it, are this going in 0.2.2?

We need to wait for a release that supports it, because 1.24.3 doesn't, which I believe is the latest? And we check currently for 1.24.0.

$ rustup toolchain install 1.58.0 --force-non-host
error: Found argument '--force-non-host' which wasn't expected, or isn't valid in this context
        Did you mean --force?

USAGE:
    rustup toolchain install <toolchain>... --force

For more information try --help
$ rustup -V
rustup 1.24.3 (ce5817a94 2021-05-31)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.61.0 (fe5b13d68 2022-05-18)

So we need to wait for a later release, but yes, if this is done prior to our 0.22 release, I think we should add this.

[otavio]

We could check for 1.24.4 as it has been merged already.

[Alexhuszagh]

Ok it seems like rustup doesn't have different branches, so it's safe to assume this will be in 1.24.4. @Emilgardis look good?

[Alexhuszagh]

I accidentally rebased it off the wrong branch, I've since fixed it. @reitermarkus can you squash the commits down to a single one and we can merge it?

[Emilgardis]

rustup 1.25.0 has been released, containing the fix

https://blog.rust-lang.org/2022/07/11/Rustup-1.25.0.html

[Alexhuszagh]

We should probably merge this quickly then.

[Emilgardis]

bors r+

[bors]

Build succeeded:

• conclusion