Draft
Conversation
b8ecb8f to
a4727a2
Compare
This implements automatic dependency resolution and linking of libraries through crytic-compile, using the existing internal mechanism provided by `--compile-libraries`. The chosen library deployment addresses are provided on a `<key>.link` JSON file when using the solc export format. This can be then used by fuzzers or other tools that would like to deploy contracts that require external libraries.
A library may live on its own source unit, separate from the contract that uses it, so we need to clean up the target contracts set at the end.
- Remove unused type: ignore comment in crytic_compile.py - Update docstring return type to modern syntax in solc.py Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Sort imports correctly - Remove unnecessary mode argument from open() Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements automatic dependency resolution and linking of libraries through crytic-compile, using the existing internal mechanism provided by
--compile-libraries. The chosen library deployment addresses are provided on a<key>.linkJSON file when using the solc export format. This can be then used by fuzzers or other tools that would like to deploy contracts that require external libraries.