Skip to content

sourcify: collect proxy information#642

Merged
smonicas merged 6 commits intomasterfrom
sourcify-improvements
Jan 20, 2026
Merged

sourcify: collect proxy information#642
smonicas merged 6 commits intomasterfrom
sourcify-improvements

Conversation

@elopez
Copy link
Copy Markdown
Member

@elopez elopez commented Jan 20, 2026

No description provided.

@dguido
Copy link
Copy Markdown
Member

dguido commented Jan 20, 2026

Code Review Note

Breaking Change: This PR renames implementation_addressimplementation_addresses and changes the type from str | None to set[str].

Downstream consumers (Slither, Echidna, Manticore) using compilation_unit.implementation_address will need to update to the new API.

Consider adding a deprecated compatibility property if backward compatibility is needed:

@property
def implementation_address(self) -> str | None:
    """Deprecated: Use implementation_addresses instead."""
    return next(iter(self._implementation_addresses), None)

Otherwise, just ensure downstream tools are updated accordingly.

@smonicas smonicas merged commit b820266 into master Jan 20, 2026
64 checks passed
@smonicas smonicas deleted the sourcify-improvements branch January 20, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants