Merged
Conversation
added 4 commits
February 23, 2019 20:39
Member
Author
|
@kof please review. |
kof
reviewed
Feb 27, 2019
| onCreateRule(key: string, frames: JssStyle, options: RuleOptions): KeyframesRule | null { | ||
| return keyRegExp.test(key) ? new KeyframesRule(key, frames, options) : null | ||
| const plugin: Plugin = { | ||
| onCreateRule(key, frames, options) { |
kof
reviewed
Feb 27, 2019
| onChangeValue(val, prop, rule) { | ||
| const {sheet} = rule.options | ||
|
|
||
| if (rule.type !== 'style' || !sheet) { |
Member
There was a problem hiding this comment.
afaik only style rule value can be changed, so the first check can be removed
added 4 commits
February 27, 2019 22:19
…frames' into feat/add-support-for-dynamic-keyframes * origin/feat/add-support-for-dynamic-keyframes: v10.0.0-alpha.11 fix changelog issue id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What would you like to add/fix?
This fixes having a dynamic animation name.
I think we can have a better system to process the update style changes and not require this duplicate code.
Still missing some tests to make sure we don't break anything.