Skip to content

React-JSS id prop docs and improvements#1147

Merged
kof merged 4 commits intomasterfrom
document-prefixing
Jul 2, 2019
Merged

React-JSS id prop docs and improvements#1147
kof merged 4 commits intomasterfrom
document-prefixing

Conversation

@kof
Copy link
Copy Markdown
Member

@kof kof commented Jun 30, 2019

Bug fixes

  • [react-jss] When id options passed to JssProvider, we need to create a new generateId function (#1147)

Improvements

  • [react-jss] Document id prop for JssProvider, add "Class name generator options" to the docs. (#1147)
  • [react-jss] Use component name or displayName as a class name prefix also in production by default (#1147)

@kof kof requested a review from HenriBeck as a code owner June 30, 2019 12:02
@kof kof self-assigned this Jun 30, 2019
@kof kof force-pushed the document-prefixing branch from ecb0b6e to 4d815aa Compare June 30, 2019 12:07
@kof kof force-pushed the document-prefixing branch from 7e9a20e to ffcf1dd Compare June 30, 2019 12:27
@kof kof changed the title React-JSS docs React-JSS id prop docs and improvements Jul 1, 2019
@kof kof merged commit c934438 into master Jul 2, 2019
HenriBeck pushed a commit that referenced this pull request Jul 6, 2019
* master: (50 commits)
  v10.0.0-alpha.22
  add react-dom dev dependenncy
  Fix SSR for Hooks based implementation (#1148)
  React-JSS id prop docs and improvements (#1147)
  v10.0.0-alpha.21
  fix changelog
  add support hint to the changelog (#1145)
  Sheets management for css() (#1137)
  Update css-vendor to 2.0.5 (#1142)
  more articles
  Small readability improvements (#1138)
  create sponsors.md (#1139)
  update karma settings
  Update css-vendor to 2.0.4 (#1136)
  v10.0.0-alpha.20
  fixing release
  v10.0.0-alpha.19
  fix lerna force-publish flag
  many more tests and some improvements to styped interface (#1133)
  v10.0.0-alpha.18
  ...

# Conflicts:
#	packages/react-jss/src/index.d.ts
HenriBeck pushed a commit that referenced this pull request Jul 7, 2019
* master:
  Use componentDidMount for WithStyles (#1157)
  Use mui like global ponyfill (#1153)
  HOC should not attach sheets until mount (#1149)
  v10.0.0-alpha.22
  add react-dom dev dependenncy
  Fix SSR for Hooks based implementation (#1148)
  React-JSS id prop docs and improvements (#1147)
  v10.0.0-alpha.21
  fix changelog
  add support hint to the changelog (#1145)
  Sheets management for css() (#1137)

# Conflicts:
#	packages/react-jss/.size-snapshot.json
bhupinderbola pushed a commit to bhupinderbola/jss that referenced this pull request Sep 17, 2019
* keep only specific to the old HOC parts in the legacy doc

* update all TOCs

* section about class name generator

* flatten sheetOptions, generate new generateId once id options changed
@iamstarkov iamstarkov deleted the document-prefixing branch October 4, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants