Skip to content

Fix the CI#1194

Merged
kof merged 6 commits intomasterfrom
updating-browsers
Sep 22, 2019
Merged

Fix the CI#1194
kof merged 6 commits intomasterfrom
updating-browsers

Conversation

@kof
Copy link
Copy Markdown
Member

@kof kof commented Sep 22, 2019

No description provided.

@kof kof requested a review from HenriBeck as a code owner September 22, 2019 09:38
@kof kof self-assigned this Sep 22, 2019
@kof
Copy link
Copy Markdown
Member Author

kof commented Sep 22, 2019 •
edited
Loading

Good news, I just figured out that all IE's keep CSS rules inserted using insertRule API when style node is detached, that's why we still have a duplication of rules in IE (cc @felthy).

I think JSS StyleSheet class needs to be refactored. Method deploy() needs to be removed and become a purely DOMRenderer implementation detail.

We currently control the deployment from both StyleSheet and DOMRenderer see, but this needs to happen in DOMRenderer and needs to be aware of browser-specific differences.

Screenshot 2019-09-22 at 13 53 06

@kof kof changed the title Updating browsers.json Fix the CI Sep 22, 2019
@kof kof requested a review from felthy September 22, 2019 13:13
@kof
Copy link
Copy Markdown
Member Author

kof commented Sep 22, 2019

the ci is finally green again

@kof kof merged commit 50c74f1 into master Sep 22, 2019
@iamstarkov iamstarkov deleted the updating-browsers branch October 4, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HenriBeck HenriBeck HenriBeck approved these changes

@felthy felthy Awaiting requested review from felthy

Assignees

@kof kof

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kof @HenriBeck
⚡