Skip to content

[default-unit] Allow options to pass function transforms in#1292

Merged
kof merged 2 commits intocssinjs:masterfrom
jkjustjoshing:master
Mar 15, 2020
Merged

[default-unit] Allow options to pass function transforms in#1292
kof merged 2 commits intocssinjs:masterfrom
jkjustjoshing:master

Conversation

@jkjustjoshing
Copy link
Copy Markdown
Contributor

@jkjustjoshing jkjustjoshing commented Mar 3, 2020

Corresponding issue (if exists):

#1291

What would you like to add/fix?

Adds the ability to transform values when adding units to them.

Todo

  • Add tests if possible
  • Add changelog if users should know about the change
  • Add documentation

@jkjustjoshing jkjustjoshing requested a review from HenriBeck as a code owner March 3, 2020 13:46
@kof
Copy link
Copy Markdown
Member

kof commented Mar 3, 2020

Well done!

@jkjustjoshing
Copy link
Copy Markdown
Contributor Author

Anything I should be doing to fix the issue with Travis CI? Looks like it's an issue out of my hands.

@kof kof merged commit bc898d0 into cssinjs:master Mar 15, 2020
@kof
Copy link
Copy Markdown
Member

kof commented Mar 15, 2020

No it's just a permission thing, we found no way to allow external contributors to run their PR's through CI with browerstack

@kof
Copy link
Copy Markdown
Member

kof commented Mar 15, 2020

released in 10.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants