Skip to content

typescript support for createUseStyles theme#1294

Merged
kof merged 1 commit intocssinjs:masterfrom
ntduan:patch-1
Mar 15, 2020
Merged

typescript support for createUseStyles theme#1294
kof merged 1 commit intocssinjs:masterfrom
ntduan:patch-1

Conversation

@ntduan
Copy link
Copy Markdown
Contributor

@ntduan ntduan commented Mar 5, 2020

Corresponding issue (if exists):

What would you like to add/fix?

Let createUseStyles have the default theme type. Like this:
image

Just add this to your project to work

declare module 'react-jss' {
  interface DefaultTheme {
    ...
  }
}

Todo

  • Add tests if possible
  • Add changelog if users should know about the change
  • Add documentation

@ntduan ntduan requested a review from HenriBeck as a code owner March 5, 2020 05:25
@kof kof added the typescript label Mar 5, 2020
@ntduan
Copy link
Copy Markdown
Contributor Author

ntduan commented Mar 11, 2020

Any progress or problems?

@kof
Copy link
Copy Markdown
Member

kof commented Mar 15, 2020

I am no expert in TS, but since no one is who is actively helping I am gonna merge this and hope you tested it.

@kof kof merged commit 05585ea into cssinjs:master Mar 15, 2020
@kof
Copy link
Copy Markdown
Member

kof commented Mar 15, 2020

Thanks

@kof
Copy link
Copy Markdown
Member

kof commented Mar 15, 2020

released in 10.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants