Skip to content

Update Classname Example#1391

Merged
kof merged 2 commits intocssinjs:masterfrom
Chartieer:patch-2
Sep 10, 2020
Merged

Update Classname Example#1391
kof merged 2 commits intocssinjs:masterfrom
Chartieer:patch-2

Conversation

@Chartieer
Copy link
Copy Markdown
Contributor

Adding a section explaining the name prop in the options object to add classname prefix on Module/Component level

Corresponding issue (if exists):

What would you like to add/fix?

Todo

  • Add tests if possible
  • Add changelog if users should know about the change
  • Add documentation

Adding a section explaining the name prop in the options object to add classname prefix on Module/Component level
@Chartieer Chartieer requested a review from HenriBeck as a code owner September 9, 2020 07:21
Comment thread docs/react-jss.md Outdated
font-style: italic;
}
```
## Adding Component Prefix Option
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I would probably write them lower case
  2. headlines need to be added to the TOC above manually

Copy link
Copy Markdown
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one more change and we are good to go

Add Toc + change header text
@Chartieer Chartieer changed the title Udate Classname Example Update Classname Example Sep 10, 2020
@kof kof merged commit cc3cea8 into cssinjs:master Sep 10, 2020
@kof
Copy link
Copy Markdown
Member

kof commented Sep 10, 2020

thanks

@kof kof mentioned this pull request Sep 10, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants