Skip to content

feat: add px as default unit for text-decoration-thickness property#1438

Merged
kof merged 1 commit intocssinjs:masterfrom
vepasto:master
Jan 4, 2021
Merged

feat: add px as default unit for text-decoration-thickness property#1438
kof merged 1 commit intocssinjs:masterfrom
vepasto:master

Conversation

@vepasto
Copy link
Copy Markdown
Contributor

@vepasto vepasto commented Jan 4, 2021

Corresponding issue (if exists):

#1437

What would you like to add/fix?

Todo

  • Add tests if possible
  • Add changelog if users should know about the change
  • Add documentation

@vepasto vepasto requested a review from HenriBeck as a code owner January 4, 2021 10:50
@kof kof merged commit acd2c75 into cssinjs:master Jan 4, 2021
@kof
Copy link
Copy Markdown
Member

kof commented Jan 4, 2021

thanks

kof added a commit that referenced this pull request Jan 19, 2021
)

* fix(react-jss): Media query styles applied only to the first element in function

chore(react-jss): Snapshot update

* tests(react-jss): added tests for createUseStyles

* added createBasicStyles call to createUseStyles test

* added media query test to createBasicTests

* feat: add px as default unit for text-decoration-thickness property (#1438)

* remove duplicate test

* rename basic to common

* rename test generator functions

* move the test where it belongs

* better comments

Co-authored-by: Pranshu Chittora <pranshuchittora17@gmail.com>
Co-authored-by: Matt Beaudry <mattb@surveymonkey.com>
Co-authored-by: Veikko Karsikko <veikko88@gmail.com>
@kof
Copy link
Copy Markdown
Member

kof commented Jan 23, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants