Conversation
ITenthusiasm
force-pushed
the
task/update-changelog
branch
from
cd7a7be to
2103982
Compare
|
Amended commit to make the use of semicolons consistent in the examples. |
| --- | ||
|
|
||
| ### Bug fixes | ||
| ## 10.6.0 (2021-03-11) |
There was a problem hiding this comment.
Gotcha. I'll remove it then.
| - [react-jss] `Theme` is no longer the first generic type parameter for `createUseStyles`. [1460](https://github.com/cssinjs/jss/pull/1460) | ||
| - There are two main ways to tell TypeScript your `Theme`'s type without reaching over the other type parameters: | ||
|
|
||
| Using the function argument. (Recommended) |
There was a problem hiding this comment.
I wouldn't encourage using this interface until we decide what to do with it, we had a discussion to remove it for various reasons
There was a problem hiding this comment.
Ah, I wasn't aware. I'll remove the "Recommended" piece then. Should the functional example be removed as well or should it stay?
|
|
||
| ```typescript | ||
| const useStyles = createUseStyles({ | ||
| className: ({theme}: {theme: Theme}) => ({ |
There was a problem hiding this comment.
className is misleading, because it would mean it's actual classname, where actual class name is generated, this is what we call a rule name
There was a problem hiding this comment.
That's fair. I'll rename it to ruleName then.
| - [jss-preset-default](https://github.com/cssinjs/jss-preset-default/blob/master/changelog.md) | ||
| - [react-jss](./docs/react-jss.md/blob/master/changelog.md) | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Yeah that one's confusing to me. 🤔 It definitely wasn't intentional. Glad you noticed it though.
|
Pushed some additional changes based on the feedback. I'll squash the commits and clean up the history when everything is finalized. |
|
If there are any other improvements that need to be made, feel free to let me know. |
|
merged, thank you! |
2 participants
This is a PR to specify the changes from #1460 in the changelog. These details are related to #1460 only. With guidance, if desired, I would gladly add any additional details that seem relevant to v10.6.0.