Conversation
kof
reviewed
Dec 31, 2018
| "build": "lerna run build", | ||
| "prepublishOnly": "yarn check-snapshots && yarn build && yarn typecheck && yarn lint && yarn format:ci && yarn test", | ||
| "build": "lerna run prepare", | ||
| "prepublish": "yarn check-snapshots && yarn build && yarn typecheck && yarn lint && yarn format:ci && yarn test", |
Member
There was a problem hiding this comment.
prepublish also runs on a regular install afaik
Member
There was a problem hiding this comment.
I mean if you clone the repo and do npm i
Member
There was a problem hiding this comment.
does yarn also do that? if not we are good
Member
Author
There was a problem hiding this comment.
Yeah, it does run on yarn install. The reason why prepublish will not work is because it's in the root package file.
I renamed the script to publish-packages
kof
approved these changes
Dec 31, 2018
bhupinderbola
pushed a commit
to bhupinderbola/jss
that referenced
this pull request
Sep 17, 2019
* Make all build scripts prepare and update lerna * Remove unnecessary lerna key inside lerna.json * Rename publish to publish-packages * Update lerna.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What would you like to add/fix?
This updates lerna to the newest version and moves all of the
buildscripts toprepare.