Skip to content

Update Travis config #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lttb merged 1 commit into from
May 31, 2017
Merged

Update Travis config #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
dist: trusty
Copy link
Copy Markdown
Member

@iamstarkov iamstarkov Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats that?

Copy link
Copy Markdown
Member Author

@lttb lttb Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis uses Ubuntu Precise as a default image, but with this option Ubuntu Trusty will be used. So official support of Precise is ending, and as I know, Travis is looking to change default image to Trusty in Q3 2017

You can get some info here

language: node_js

node_js:
- 7
Copy link
Copy Markdown
Member

@iamstarkov iamstarkov Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you want to run tests on all LTS versions?

Copy link
Copy Markdown
Member Author

@lttb lttb Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that it's necessary, because we don't use node-specific features, and transpiled code should work with node from v4.

But if there are some issues with, we can run tests on all versions of course

Copy link
Copy Markdown
Member

@iamstarkov iamstarkov Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually find it pretty convenient to run tests on all LTS + latest version


after_success: npm run test:coverage && npm run coveralls
cache: yarn

script:
- yarn --version
- npm run flow
- npm run lint
- npm run test:coverage && npm run coveralls
⚡