You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the previous code, the Geoip service was using the Request IP.
In most of the case that works well but if the website is behind CloudFlare, the IP will be the proxy one.
Now it determines user's real IP if behind cloudflare or not. Fixes#499#491
Tell me if you think something needs to be ajusted.
This needs to be a config option. If it can't be turned off, then Polr administrators who do not deploy Polr behind a reverse proxy are left vulnerable to forged X-Forwarded-For HTTP headers, or whatever similar mechanism this API call uses (there is no way to securely determine whether X-Forwarded-For is authentic or not without this being set administratively in the config file).
This needs to be a config option. If it can't be turned off, then Polr administrators who do not deploy Polr behind a reverse proxy are left vulnerable to forged X-Forwarded-For HTTP headers, or whatever similar mechanism this API call uses (there is no way to securely determine whether X-Forwarded-For is authentic or not without this being set administratively in the config file).
Fair point, will think about that.
The project looks a bit dead, don't think I will make a new PR to add that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the previous code, the Geoip service was using the Request IP.
In most of the case that works well but if the website is behind CloudFlare, the IP will be the proxy one.
Now it determines user's real IP if behind cloudflare or not. Fixes #499 #491
Tell me if you think something needs to be ajusted.