PR resolving issue #516

app/Factories/LinkFactory.php

@@ -48,6 +48,10 @@ public static function createLink($long_url, $is_secret=false, $custom_ending=nu
                 maximum length allowed.');
         }
 
+        if (LinkHelper::checkIfShortlinkIsRegisteredRoute($custom_ending)) {
+            throw new \Exception('Sorry, but your ending is a prohibited ending');
+        }
+
         $is_already_short = LinkHelper::checkIfAlreadyShortened($long_url);
 
         if ($is_already_short) {

app/Helpers/LinkHelper.php

@@ -142,4 +142,25 @@ static public function findSuitableEnding() {
 
         return $base_x_val;
     }
+
+    /**
+     * Checks if the ending is a registered route
+     * @param string $ending the requested ending
+     * @return bool true - it is a registered route; false - it is not
+     */
+    static public function checkIfShortlinkIsRegisteredRoute($ending)
+    {
+        $publicDirectories = ['css', 'directives', 'fonts', 'img', 'js'];
+        if (in_array($ending, $publicDirectories, true)) {
+            return true;
+        }
+        $routes = property_exists(app(), 'router') ? app()->router->getRoutes() : app()->getRoutes();
+        foreach ($routes as $route) {
+            $routeName = (isset($route['action']['as'])) ? $route['action']['as'] : '';
+            if ($ending === $routeName) {
+                return true;
+            }
+        }
+        return false;
+    }
 }

tests/LinkFactoryTest.php

@@ -0,0 +1,16 @@
+<?php
+
+
+use App\Factories\LinkFactory;
+
+class LinkFactoryTest extends TestCase
+{
+    public function testLinkIsProhibitedEnding()
+    {
+        $this->setExpectedException(\Exception::class, 'Sorry, but your ending is a prohibited ending');
+        LinkFactory::createLink('https://example.org', true, 'login', '127.0.0.1', false, true);
+
+        $this->setExpectedException(\Exception::class, 'Sorry, but your ending is a prohibited ending');
+        LinkFactory::createLink('https://example.org', true, 'js', '127.0.0.1', false, true);
+    }
+}